greybus: power_supply: fix error path at supplies setup (d9eafd58) · Commits · 戴 / test

If something goes wrong at setup time for the supplies, we need to release all the resources allocated already. Call the supplies release function which will handle the correct teardown of the supplies. Signed-off-by:

Rui Miguel Silva <rui.silva@linaro.org> Reported-by:

Johan Hovold <johan@hovoldconsulting.com> Reviewed-by:

Johan Hovold <johan@hovoldconsulting.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@google.com>

drivers/staging/greybus/power_supply.c

+6 −1

Original line number	Diff line number	Diff line
		@@ -731,6 +731,7 @@ out_unlock:
		static int gb_power_supply_connection_init(struct gb_connection *connection)
		{
		struct gb_power_supplies *supplies;
		int ret;

		supplies = kzalloc(sizeof(*supplies), GFP_KERNEL);
		if (!supplies)
		@@ -741,7 +742,11 @@ static int gb_power_supply_connection_init(struct gb_connection *connection)

		mutex_init(&supplies->supplies_lock);

		return gb_power_supplies_setup(supplies);
		ret = gb_power_supplies_setup(supplies);
		if (ret < 0)
		_gb_power_supplies_release(supplies);

		return ret;
		}

		static void gb_power_supply_connection_exit(struct gb_connection *connection)

Admin message