Commit d9da466a authored by vignesh babu's avatar vignesh babu Committed by Jeff Garzik
Browse files

use is_power_of_2() in cxgb3/cxgb3_main.c 



Replace (n & (n-1)) with is_power_of_2()

Signed-off-by: default avatarvignesh babu <vignesh.babu@wipro.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent de0d3dc0

drivers/net/cxgb3/cxgb3_main.c

+3 −2
Original line number Diff line number Diff line
@@ -43,6 +43,7 @@ 
#include <linux/proc_fs.h>

#include <linux/rtnetlink.h>

#include <linux/firmware.h>

#include <linux/log2.h>

#include <asm/uaccess.h>



#include "common.h"
@@ -1818,8 +1819,8 @@ static int cxgb_extension_ioctl(struct net_device *dev, void __user *useraddr) 
			return -EBUSY;

		if (copy_from_user(&m, useraddr, sizeof(m)))

			return -EFAULT;

		if (!m.rx_pg_sz || (m.rx_pg_sz & (m.rx_pg_sz - 1)) ||

			!m.tx_pg_sz || (m.tx_pg_sz & (m.tx_pg_sz - 1)))

		if (!is_power_of_2(m.rx_pg_sz) ||

			!is_power_of_2(m.tx_pg_sz))

			return -EINVAL;	/* not power of 2 */

		if (!(m.rx_pg_sz & 0x14000))

			return -EINVAL;	/* not 16KB or 64KB */

CRA Git | Maintained and supported by SUSTech CRA and CCSE