Commit d9b0e599 authored Oct 20, 2020 by Lijun Pan Committed by Jakub Kicinski Oct 21, 2020

ibmvnic: save changed mac address to adapter->mac_addr



After mac address change request completes successfully, the new mac
address need to be saved to adapter->mac_addr as well as
netdev->dev_addr. Otherwise, adapter->mac_addr still holds old
data.

Fixes: 62740e97 ("net/ibmvnic: Update MAC address settings after adapter reset")
Signed-off-by: Lijun Pan <ljp@linux.ibm.com>
Link: https://lore.kernel.org/r/20201020223919.46106-1-ljp@linux.ibm.com


Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 287d3540

drivers/net/ethernet/ibm/ibmvnic.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -4235,8 +4235,13 @@ static int handle_change_mac_rsp(union ibmvnic_crq *crq,
		dev_err(dev, "Error %ld in CHANGE_MAC_ADDR_RSP\n", rc);
		goto out;
		}
		/* crq->change_mac_addr.mac_addr is the requested one
		* crq->change_mac_addr_rsp.mac_addr is the returned valid one.
		*/
		ether_addr_copy(netdev->dev_addr,
		&crq->change_mac_addr_rsp.mac_addr[0]);
		ether_addr_copy(adapter->mac_addr,
		&crq->change_mac_addr_rsp.mac_addr[0]);
		out:
		complete(&adapter->fw_done);
		return rc;

Admin message