Commit d9a9dc66 authored Jul 16, 2010 by Arnaud Ebalard Committed by David S. Miller Jul 18, 2010

IPv6: fix CoA check in RH2 input handler (mip6_rthdr_input())



The input handler for Type 2 Routing Header (mip6_rthdr_input())
checks if the CoA in the packet matches the CoA in the XFRM state.

Current check is buggy: it compares the adddress in the Type 2
Routing Header, i.e. the HoA, against the expected CoA in the state.
The comparison should be made against the address in the destination
field of the IPv6 header.

The bug remained unnoticed because the main (and possibly only current)
user of the code (UMIP MIPv6 Daemon) initializes the XFRM state with the
unspecified address, i.e. explicitly allows everything.

Yoshifuji-san, can you ack that one?

Signed-off-by: Arnaud Ebalard <arno@natisbad.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent ee2e6114

net/ipv6/mip6.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -347,11 +347,12 @@ static const struct xfrm_type mip6_destopt_type =

		static int mip6_rthdr_input(struct xfrm_state x, struct sk_buff skb)
		{
		struct ipv6hdr *iph = ipv6_hdr(skb);
		struct rt2_hdr rt2 = (struct rt2_hdr )skb->data;
		int err = rt2->rt_hdr.nexthdr;

		spin_lock(&x->lock);
		if (!ipv6_addr_equal(&rt2->addr, (struct in6_addr *)x->coaddr) &&
		if (!ipv6_addr_equal(&iph->daddr, (struct in6_addr *)x->coaddr) &&
		!ipv6_addr_any((struct in6_addr *)x->coaddr))
		err = -ENOENT;
		spin_unlock(&x->lock);

Admin message