Commit d9a82a04 authored by Andreas Gruenbacher's avatar Andreas Gruenbacher Committed by Al Viro
Browse files

xattr handlers: Pass handler to operations instead of flags 



The xattr_handler operations are currently all passed a file system
specific flags value which the operations can use to disambiguate between
different handlers; some file systems use that to distinguish the xattr
namespace, for example.  In some oprations, it would be useful to also have
access to the handler prefix.  To allow that, pass a pointer to the handler
to operations instead of the flags value alone.

Signed-off-by: default avatarAndreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent bf781714

fs/9p/acl.c

+10 −8
Original line number Diff line number Diff line
@@ -230,11 +230,13 @@ static int v9fs_remote_get_acl(struct dentry *dentry, const char *name, 
	return v9fs_xattr_get(dentry, full_name, buffer, size);

}



static int v9fs_xattr_get_acl(struct dentry *dentry, const char *name,

			      void *buffer, size_t size, int type)

static int v9fs_xattr_get_acl(const struct xattr_handler *handler,

			      struct dentry *dentry, const char *name,

			      void *buffer, size_t size)

{

	struct v9fs_session_info *v9ses;

	struct posix_acl *acl;

	int type = handler->flags;

	int error;



	if (strcmp(name, "") != 0)
@@ -278,9 +280,9 @@ static int v9fs_remote_set_acl(struct dentry *dentry, const char *name, 
}





static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name,

			      const void *value, size_t size,

			      int flags, int type)

static int v9fs_xattr_set_acl(const struct xattr_handler *handler,

			      struct dentry *dentry, const char *name,

			      const void *value, size_t size, int flags)

{

	int retval;

	struct posix_acl *acl;
@@ -297,7 +299,7 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name, 
	 */

	if ((v9ses->flags & V9FS_ACCESS_MASK) != V9FS_ACCESS_CLIENT)

		return v9fs_remote_set_acl(dentry, name,

					   value, size, flags, type);

					   value, size, flags, handler->flags);



	if (S_ISLNK(inode->i_mode))

		return -EOPNOTSUPP;
@@ -316,7 +318,7 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name, 
	} else

		acl = NULL;



	switch (type) {

	switch (handler->flags) {

	case ACL_TYPE_ACCESS:

		name = POSIX_ACL_XATTR_ACCESS;

		if (acl) {
@@ -360,7 +362,7 @@ static int v9fs_xattr_set_acl(struct dentry *dentry, const char *name, 
	}

	retval = v9fs_xattr_set(dentry, name, value, size, flags);

	if (!retval)

		set_cached_acl(inode, type, acl);

		set_cached_acl(inode, handler->flags, acl);

err_out:

	posix_acl_release(acl);

	return retval;

fs/9p/xattr_security.c

+6 −4
Original line number Diff line number Diff line
@@ -19,8 +19,9 @@ 
#include <linux/slab.h>

#include "xattr.h"



static int v9fs_xattr_security_get(struct dentry *dentry, const char *name,

			void *buffer, size_t size, int type)

static int v9fs_xattr_security_get(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			void *buffer, size_t size)

{

	int retval;

	char *full_name;
@@ -46,8 +47,9 @@ static int v9fs_xattr_security_get(struct dentry *dentry, const char *name, 
	return retval;

}



static int v9fs_xattr_security_set(struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags, int type)

static int v9fs_xattr_security_set(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags)

{

	int retval;

	char *full_name;

fs/9p/xattr_trusted.c

+6 −4
Original line number Diff line number Diff line
@@ -19,8 +19,9 @@ 
#include <linux/slab.h>

#include "xattr.h"



static int v9fs_xattr_trusted_get(struct dentry *dentry, const char *name,

			void *buffer, size_t size, int type)

static int v9fs_xattr_trusted_get(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			void *buffer, size_t size)

{

	int retval;

	char *full_name;
@@ -46,8 +47,9 @@ static int v9fs_xattr_trusted_get(struct dentry *dentry, const char *name, 
	return retval;

}



static int v9fs_xattr_trusted_set(struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags, int type)

static int v9fs_xattr_trusted_set(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags)

{

	int retval;

	char *full_name;

fs/9p/xattr_user.c

+6 −4
Original line number Diff line number Diff line
@@ -19,8 +19,9 @@ 
#include <linux/slab.h>

#include "xattr.h"



static int v9fs_xattr_user_get(struct dentry *dentry, const char *name,

			void *buffer, size_t size, int type)

static int v9fs_xattr_user_get(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			void *buffer, size_t size)

{

	int retval;

	char *full_name;
@@ -46,8 +47,9 @@ static int v9fs_xattr_user_get(struct dentry *dentry, const char *name, 
	return retval;

}



static int v9fs_xattr_user_set(struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags, int type)

static int v9fs_xattr_user_set(const struct xattr_handler *handler,

			struct dentry *dentry, const char *name,

			const void *value, size_t size, int flags)

{

	int retval;

	char *full_name;

fs/ext2/xattr.c

+3 −4
Original line number Diff line number Diff line
@@ -293,10 +293,9 @@ bad_block: ext2_error(inode->i_sb, "ext2_xattr_list", 
			ext2_xattr_handler(entry->e_name_index);



		if (handler) {

			size_t size = handler->list(dentry, buffer, rest,

						    entry->e_name,

						    entry->e_name_len,

						    handler->flags);

			size_t size = handler->list(handler, dentry, buffer,

						    rest, entry->e_name,

						    entry->e_name_len);

			if (buffer) {

				if (size > rest) {

					error = -ERANGE;

CRA Git | Maintained and supported by SUSTech CRA and CCSE