Commit d99f160a authored by Eric W. Biederman's avatar Eric W. Biederman Committed by Linus Torvalds
Browse files

[PATCH] sysctl: allow a zero ctl_name in the middle of a sysctl table 



Since it is becoming clear that there are just enough users of the binary
sysctl interface that completely removing the binary interface from the kernel
will not be an option for foreseeable future, we need to find a way to address
the sysctl maintenance issues.

The basic problem is that sysctl requires one central authority to allocate
sysctl numbers, or else conflicts and ABI breakage occur.  The proc interface
to sysctl does not have that problem, as names are not densely allocated.

By not terminating a sysctl table until I have neither a ctl_name nor a
procname, it becomes simple to add sysctl entries that don't show up in the
binary sysctl interface.  Which allows people to avoid allocating a binary
sysctl value when not needed.

I have audited the kernel code and in my reading I have not found a single
sysctl table that wasn't terminated by a completely zero filled entry.  So
this change in behavior should not affect anything.

I think this mechanism eases the pain enough that combined with a little
disciple we can solve the reoccurring sysctl ABI breakage.

Signed-off-by: default avatarEric W. Biederman <ebiederm@xmission.com>
Acked-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 0e009be8

include/linux/sysctl.h

+6 −3
Original line number Diff line number Diff line
@@ -961,8 +961,8 @@ extern ctl_handler sysctl_ms_jiffies; 
/*

 * Register a set of sysctl names by calling register_sysctl_table

 * with an initialised array of ctl_table's.  An entry with zero

 * ctl_name terminates the table.  table->de will be set up by the

 * registration and need not be initialised in advance.

 * ctl_name and NULL procname terminates the table.  table->de will be

 * set up by the registration and need not be initialised in advance.

 *

 * sysctl names can be mirrored automatically under /proc/sys.  The

 * procname supplied controls /proc naming.
@@ -974,6 +974,9 @@ extern ctl_handler sysctl_ms_jiffies; 
 * under /proc; non-leaf nodes will be represented by directories.  A

 * null procname disables /proc mirroring at this node.

 *

 * sysctl entries with a zero ctl_name will not be available through

 * the binary sysctl interface.

 *

 * sysctl(2) can automatically manage read and write requests through

 * the sysctl table.  The data and maxlen fields of the ctl_table

 * struct enable minimal validation of the values being written to be

kernel/sysctl.c

+5 −3
Original line number Diff line number Diff line
@@ -1315,7 +1315,9 @@ repeat: 
		return -ENOTDIR;

	if (get_user(n, name))

		return -EFAULT;

	for ( ; table->ctl_name; table++) {

	for ( ; table->ctl_name || table->procname; table++) {

		if (!table->ctl_name)

			continue;

		if (n == table->ctl_name || table->ctl_name == CTL_ANY) {

			int error;

			if (table->child) {
@@ -1532,7 +1534,7 @@ static void register_proc_table(ctl_table * table, struct proc_dir_entry *root, 
	int len;

	mode_t mode;

	

	for (; table->ctl_name; table++) {

	for (; table->ctl_name || table->procname; table++) {

		/* Can't do anything without a proc name. */

		if (!table->procname)

			continue;
@@ -1579,7 +1581,7 @@ static void register_proc_table(ctl_table * table, struct proc_dir_entry *root, 
static void unregister_proc_table(ctl_table * table, struct proc_dir_entry *root)

{

	struct proc_dir_entry *de;

	for (; table->ctl_name; table++) {

	for (; table->ctl_name || table->procname; table++) {

		if (!(de = table->de))

			continue;

		if (de->mode & S_IFDIR) {

CRA Git | Maintained and supported by SUSTech CRA and CCSE