Commit d9973871 authored by Oded Gabbay's avatar Oded Gabbay
Browse files

habanalabs: keep track of the device's dma mask 



This patch refactors the code that is responsible to set the DMA mask for
the device.

Upon each change of the dma mask, the driver will save the new value that
was set. This is needed in order to make sure we don't try to increase the
mask a second time, in case we failed in the first time. This is
especially relevant for Power machines, as that may cause a change in
configuration of the TVT which will break the device.

Goya will first try to set the device's dma mask to 39 bits, so that the
memory that is allocated on the host machine for communication with the
device's cpu will be in a bus address which is lower then 39 bits. Later,
Goya will try to increase that mask to 48 bits, but only if setting the
mask to 39 bits was successful.

Signed-off-by: default avatarOded Gabbay <oded.gabbay@gmail.com>
parent 66542c3b

drivers/misc/habanalabs/goya/goya.c

+10 −22
Original line number Diff line number Diff line
@@ -482,7 +482,7 @@ static int goya_early_init(struct hl_device *hdev) 


	prop->dram_pci_bar_size = pci_resource_len(pdev, DDR_BAR_ID);



	rc = hl_pci_init(hdev);

	rc = hl_pci_init(hdev, 39);

	if (rc)

		return rc;
@@ -2445,29 +2445,17 @@ static int goya_hw_init(struct hl_device *hdev) 
		goto disable_msix;

	}



	/* CPU initialization is finished, we can now move to 48 bit DMA mask */

	rc = pci_set_dma_mask(hdev->pdev, DMA_BIT_MASK(48));

	if (rc) {

		dev_warn(hdev->dev, "Unable to set pci dma mask to 48 bits\n");

		rc = pci_set_dma_mask(hdev->pdev, DMA_BIT_MASK(32));

		if (rc) {

			dev_err(hdev->dev,

				"Unable to set pci dma mask to 32 bits\n");

			goto disable_pci_access;

		}

	}



	rc = pci_set_consistent_dma_mask(hdev->pdev, DMA_BIT_MASK(48));

	if (rc) {

		dev_warn(hdev->dev,

			"Unable to set pci consistent dma mask to 48 bits\n");

		rc = pci_set_consistent_dma_mask(hdev->pdev, DMA_BIT_MASK(32));

		if (rc) {

			dev_err(hdev->dev,

				"Unable to set pci consistent dma mask to 32 bits\n");

	/*

	 * Check if we managed to set the DMA mask to more then 32 bits. If so,

	 * let's try to increase it again because in Goya we set the initial

	 * dma mask to less then 39 bits so that the allocation of the memory

	 * area for the device's cpu will be under 39 bits

	 */

	if (hdev->dma_mask > 32) {

		rc = hl_pci_set_dma_mask(hdev, 48);

		if (rc)

			goto disable_pci_access;

	}

	}



	/* Perform read from the device to flush all MSI-X configuration */

	val = RREG32(mmPCIE_DBI_DEVICE_ID_VENDOR_ID_REG);

drivers/misc/habanalabs/habanalabs.h

+4 −1
Original line number Diff line number Diff line
@@ -1106,6 +1106,7 @@ struct hl_device_reset_work { 
 * @init_done: is the initialization of the device done.

 * @mmu_enable: is MMU enabled.

 * @device_cpu_disabled: is the device CPU disabled (due to timeouts)

 * @dma_mask: the dma mask that was set for this device

 */

struct hl_device {

	struct pci_dev			*pdev;
@@ -1176,6 +1177,7 @@ struct hl_device { 
	u8				dram_default_page_mapping;

	u8				init_done;

	u8				device_cpu_disabled;

	u8				dma_mask;



	/* Parameters for bring-up */

	u8				mmu_enable;
@@ -1397,8 +1399,9 @@ int hl_pci_set_dram_bar_base(struct hl_device *hdev, u8 inbound_region, u8 bar, 
				u64 addr);

int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address,

			u64 dram_base_address, u64 host_phys_size);

int hl_pci_init(struct hl_device *hdev);

int hl_pci_init(struct hl_device *hdev, u8 dma_mask);

void hl_pci_fini(struct hl_device *hdev);

int hl_pci_set_dma_mask(struct hl_device *hdev, u8 dma_mask);



long hl_get_frequency(struct hl_device *hdev, u32 pll_index, bool curr);

void hl_set_frequency(struct hl_device *hdev, u32 pll_index, u64 freq);

drivers/misc/habanalabs/habanalabs_drv.c

+3 −0
Original line number Diff line number Diff line
@@ -229,6 +229,9 @@ int create_hdev(struct hl_device **dev, struct pci_dev *pdev, 
		hdev->asic_type = asic_type;

	}



	/* Set default DMA mask to 32 bits */

	hdev->dma_mask = 32;



	mutex_lock(&hl_devs_idr_lock);



	if (minor == -1) {

drivers/misc/habanalabs/pci.c

+48 −16
Original line number Diff line number Diff line
@@ -287,42 +287,74 @@ int hl_pci_init_iatu(struct hl_device *hdev, u64 sram_base_address, 
}



/**

 * hl_pci_init() - PCI initialization code.

 * hl_pci_set_dma_mask() - Set DMA masks for the device.

 * @hdev: Pointer to hl_device structure.

 * @dma_mask: number of bits for the requested dma mask.

 *

 * Set DMA masks, initialize the PCI controller and map the PCI BARs.

 * This function sets the DMA masks (regular and consistent) for a specified

 * value. If it doesn't succeed, it tries to set it to a fall-back value

 *

 * Return: 0 on success, non-zero for failure.

 */

int hl_pci_init(struct hl_device *hdev)

int hl_pci_set_dma_mask(struct hl_device *hdev, u8 dma_mask)

{

	struct pci_dev *pdev = hdev->pdev;

	int rc;



	/* set DMA mask */

	rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(39));

	rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(dma_mask));

	if (rc) {

		dev_warn(hdev->dev, "Unable to set pci dma mask to 39 bits\n");

		rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));

		dev_warn(hdev->dev,

			"Failed to set pci dma mask to %d bits, error %d\n",

			dma_mask, rc);



		dma_mask = hdev->dma_mask;



		rc = pci_set_dma_mask(pdev, DMA_BIT_MASK(dma_mask));

		if (rc) {

			dev_err(hdev->dev,

				"Unable to set pci dma mask to 32 bits\n");

				"Failed to set pci dma mask to %d bits, error %d\n",

				dma_mask, rc);

			return rc;

		}

	}



	rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(39));

	if (rc) {

		dev_warn(hdev->dev,

			"Unable to set pci consistent dma mask to 39 bits\n");

		rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(32));

	/*

	 * We managed to set the dma mask, so update the dma mask field. If

	 * the set to the coherent mask will fail with that mask, we will

	 * fail the entire function

	 */

	hdev->dma_mask = dma_mask;



	rc = pci_set_consistent_dma_mask(pdev, DMA_BIT_MASK(dma_mask));

	if (rc) {

		dev_err(hdev->dev,

				"Unable to set pci consistent dma mask to 32 bits\n");

			"Failed to set pci consistent dma mask to %d bits, error %d\n",

			dma_mask, rc);

		return rc;

	}



	return 0;

}



/**

 * hl_pci_init() - PCI initialization code.

 * @hdev: Pointer to hl_device structure.

 * @dma_mask: number of bits for the requested dma mask.

 *

 * Set DMA masks, initialize the PCI controller and map the PCI BARs.

 *

 * Return: 0 on success, non-zero for failure.

 */

int hl_pci_init(struct hl_device *hdev, u8 dma_mask)

{

	struct pci_dev *pdev = hdev->pdev;

	int rc;



	rc = hl_pci_set_dma_mask(hdev, dma_mask);

	if (rc)

		return rc;



	if (hdev->reset_pcilink)

		hl_pci_reset_link_through_bridge(hdev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE