Commit d9873969 authored Oct 30, 2018 by Rasmus Villemoes Committed by Linus Torvalds Oct 31, 2018

linux/bitmap.h: fix type of nbits in bitmap_shift_right()

Most other bitmap API, including the OOL version __bitmap_shift_right,
take unsigned nbits.  This was accidentally left out from 2fbad299.

Link: http://lkml.kernel.org/r/20180818131623.8755-5-linux@rasmusvillemoes.dk


Fixes: 2fbad299 ("lib: bitmap: change bitmap_shift_right to take unsigned parameters")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reported-by: Yury Norov <ynorov@caviumnetworks.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent c8cebc55

include/linux/bitmap.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -391,7 +391,7 @@ static __always_inline void bitmap_clear(unsigned long *map, unsigned int start,
		}

		static inline void bitmap_shift_right(unsigned long dst, const unsigned long src,
		unsigned int shift, int nbits)
		unsigned int shift, unsigned int nbits)
		{
		if (small_const_nbits(nbits))
		dst = (src & BITMAP_LAST_WORD_MASK(nbits)) >> shift;

Admin message