Commit d97de888 authored Aug 07, 2019 by Mark Zhang Committed by Doug Ledford Aug 07, 2019

RDMA/counter: Prevent QP counter binding if counters unsupported



In case of rdma_counter_init() fails, counter allocation and QP bind
should not be allowed.

Fixes: 413d3347 ("RDMA/counter: Add set/clear per-port auto mode support")
Fixes: 1bd8e0a9 ("RDMA/counter: Allow manual mode configuration support")
Signed-off-by: Mark Zhang <markz@mellanox.com>
Reviewed-by: Parav Pandit <parav@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Link: https://lore.kernel.org/r/20190807101819.7581-1-leon@kernel.org


Signed-off-by: Doug Ledford <dledford@redhat.com>

parent f591822c

drivers/infiniband/core/counters.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -38,6 +38,9 @@ int rdma_counter_set_auto_mode(struct ib_device *dev, u8 port,
		int ret;

		port_counter = &dev->port_data[port].port_counter;
		if (!port_counter->hstats)
		return -EOPNOTSUPP;

		mutex_lock(&port_counter->lock);
		if (on) {
		ret = __counter_set_mode(&port_counter->mode,
		@@ -509,6 +512,9 @@ int rdma_counter_bind_qpn_alloc(struct ib_device *dev, u8 port,
		if (!rdma_is_port_valid(dev, port))
		return -EINVAL;

		if (!dev->port_data[port].port_counter.hstats)
		return -EOPNOTSUPP;

		qp = rdma_counter_get_qp(dev, qp_num);
		if (!qp)
		return -ENOENT;

Admin message