Commit d9798143 authored by Mike Rapoport's avatar Mike Rapoport Committed by Greg Kroah-Hartman
Browse files

staging: sm750fb: use BIT macro for VGA_CONFIGURATION single-bit fields 



Replace complex defintion of VGA_CONFIGURATION register fields with BIT()
macro and use open-coded implementation for VGA_CONFIGURATION
manipulations.

Signed-off-by: default avatarMike Rapoport <mike.rapoport@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent cf25a704

drivers/staging/sm750fb/ddk750_chip.c

+1 −2
Original line number Diff line number Diff line
@@ -211,8 +211,7 @@ int ddk750_initHw(initchip_param_t *pInitParam) 
	if (getChipType() != SM750LE) {

		/*	set panel pll and graphic mode via mmio_88 */

		reg = PEEK32(VGA_CONFIGURATION);

		reg = FIELD_SET(reg, VGA_CONFIGURATION, PLL, PANEL);

		reg = FIELD_SET(reg, VGA_CONFIGURATION, MODE, GRAPHIC);

		reg |= (VGA_CONFIGURATION_PLL | VGA_CONFIGURATION_MODE);

		POKE32(VGA_CONFIGURATION, reg);

	} else {

#if defined(__i386__) || defined(__x86_64__)

drivers/staging/sm750fb/ddk750_reg.h

+2 −6
Original line number Diff line number Diff line
@@ -548,12 +548,8 @@ 


#define VGA_CONFIGURATION                             0x000088

#define VGA_CONFIGURATION_USER_DEFINE                 5:4

#define VGA_CONFIGURATION_PLL                         2:2

#define VGA_CONFIGURATION_PLL_VGA                     0

#define VGA_CONFIGURATION_PLL_PANEL                   1

#define VGA_CONFIGURATION_MODE                        1:1

#define VGA_CONFIGURATION_MODE_TEXT                   0

#define VGA_CONFIGURATION_MODE_GRAPHIC                1

#define VGA_CONFIGURATION_PLL                         BIT(2)

#define VGA_CONFIGURATION_MODE                        BIT(1)



#endif

CRA Git | Maintained and supported by SUSTech CRA and CCSE