Commit d9771f5e authored Jun 14, 2019 by Xiao Ni Committed by Jens Axboe Jun 15, 2019

raid5-cache: Need to do start() part job after adding journal device



commit d5d885fd ("md: introduce new personality funciton start()")
splits the init job to two parts. The first part run() does the jobs that
do not require the md threads. The second part start() does the jobs that
require the md threads.

Now it just does run() in adding new journal device. It needs to do the
second part start() too.

Fixes: d5d885fd ("md: introduce new personality funciton start()")
Cc: stable@vger.kernel.org #v4.9+
Reported-by: Michal Soltys <soltys@ziu.info>
Signed-off-by: Xiao Ni <xni@redhat.com>
Signed-off-by: Song Liu <songliubraving@fb.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 3f677f9c

drivers/md/raid5.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -7672,7 +7672,7 @@ abort:
		static int raid5_add_disk(struct mddev mddev, struct md_rdev rdev)
		{
		struct r5conf *conf = mddev->private;
		int err = -EEXIST;
		int ret, err = -EEXIST;
		int disk;
		struct disk_info *p;
		int first = 0;
		@@ -7687,7 +7687,14 @@ static int raid5_add_disk(struct mddev mddev, struct md_rdev rdev)
		* The array is in readonly mode if journal is missing, so no
		* write requests running. We should be safe
		*/
		log_init(conf, rdev, false);
		ret = log_init(conf, rdev, false);
		if (ret)
		return ret;

		ret = r5l_start(conf->log);
		if (ret)
		return ret;

		return 0;
		}
		if (mddev->recovery_disabled == conf->recovery_disabled)

Admin message