Commit d95f20c4 authored Jan 23, 2020 by Dongdong Liu Committed by Bjorn Helgaas Jan 23, 2020

PCI/AER: Initialize aer_fifo

Previously we did not call INIT_KFIFO() for aer_fifo.  This leads to
kfifo_put() sometimes returning 0 (queue full) when in fact it is not.

It is easy to reproduce the problem by using aer-inject:

  $ aer-inject -s :82:00.0 multiple-corr-nonfatal

The content of the multiple-corr-nonfatal file is as below:

  AER
  COR RCVR
  HL 0 1 2 3
  AER
  UNCOR POISON_TLP
  HL 4 5 6 7

Fixes: 27c1ce8b ("PCI/AER: Use kfifo for tracking events instead of reimplementing it")
Link: https://lore.kernel.org/r/1579767991-103898-1-git-send-email-liudongdong3@huawei.com


Signed-off-by: Dongdong Liu <liudongdong3@huawei.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 8d077c3c

drivers/pci/pcie/aer.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1445,6 +1445,7 @@ static int aer_probe(struct pcie_device *dev)
		return -ENOMEM;

		rpc->rpd = port;
		INIT_KFIFO(rpc->aer_fifo);
		set_service_data(dev, rpc);

		status = devm_request_threaded_irq(device, dev->irq, aer_irq, aer_isr,

Admin message