Commit d935bd50 authored Nov 27, 2019 by Geert Uytterhoeven Committed by Linus Walleij Dec 09, 2019

gpio: Fix error message on out-of-range GPIO in lookup table



When a GPIO offset in a lookup table is out-of-range, the printed error
message (1) does not include the actual out-of-range value, and (2)
contains an off-by-one error in the upper bound.

Avoid user confusion by also printing the actual GPIO offset, and
correcting the upper bound of the range.
While at it, use "%u" for unsigned int.

Sample impact:

    -requested GPIO 0 is out of range [0..32] for chip e6052000.gpio
    +requested GPIO 0 (45) is out of range [0..31] for chip e6052000.gpio

Fixes: 2a3cf6a3 ("gpiolib: return -ENOENT if no GPIO mapping exists")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://lore.kernel.org/r/20191127095919.4214-1-geert+renesas@glider.be


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 322f6a31

drivers/gpio/gpiolib.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -4472,8 +4472,9 @@ static struct gpio_desc gpiod_find(struct device dev, const char *con_id,

		if (chip->ngpio <= p->chip_hwnum) {
		dev_err(dev,
		"requested GPIO %d is out of range [0..%d] for chip %s\n",
		idx, chip->ngpio, chip->label);
		"requested GPIO %u (%u) is out of range [0..%u] for chip %s\n",
		idx, p->chip_hwnum, chip->ngpio - 1,
		chip->label);
		return ERR_PTR(-EINVAL);
		}

Admin message