Commit d9350f21 authored by Aditya Pakki's avatar Aditya Pakki Committed by Sudeep Holla
Browse files

firmware: arm_scmi: replace of_match_device->data with of_device_get_match_data()



of_match_device can return NULL if no matching device is found though
it's highly unlikely to happen in scmi_probe as it's called only if
a valid match is found.

However we can use of_device_get_match_data() instead of
of_match_device()->data to handle NULL pointer checks and return -EINVAL
in such a scenario.

Reviewed-by: default avatarSteven Price <steven.price@arm.com>
Signed-off-by: default avatarAditya Pakki <pakki001@umn.edu>
Signed-off-by: default avatarSudeep Holla <sudeep.holla@arm.com>
parent fa7fe29a
Loading
Loading
Loading
Loading
+3 −1
Original line number Diff line number Diff line
@@ -796,7 +796,9 @@ static int scmi_probe(struct platform_device *pdev)
		return -EINVAL;
	}

	desc = of_match_device(scmi_of_match, dev)->data;
	desc = of_device_get_match_data(dev);
	if (!desc)
		return -EINVAL;

	info = devm_kzalloc(dev, sizeof(*info), GFP_KERNEL);
	if (!info)