Commit d92e74d3 authored by Alan Cox's avatar Alan Cox Committed by Jeff Garzik
Browse files

libata-core/sff: Fix multiple assumptions about DMA 



The ata IRQ ack functions are only used when debugging. Unfortunately
almost every controller that calls them can cause crashes in some
configurations as there are missing checks for bmdma presence.

In addition ata_port_start insists of installing DMA buffers and pad
buffers for controllers regardless. The SFF controllers actually need to
make that decision dynamically at controller setup time and all need the
same helper - so we add ata_sff_port_start. Future patches will switch
the SFF drivers to use this.

Signed-off-by: default avatarAlan Cox <alan@redhat.com>
Signed-off-by: default avatarJeff Garzik <jeff@garzik.org>
parent 0522b286

drivers/ata/libata-core.c

+1 −0
Original line number Diff line number Diff line
@@ -6826,6 +6826,7 @@ EXPORT_SYMBOL_GPL(ata_check_status); 
EXPORT_SYMBOL_GPL(ata_altstatus);

EXPORT_SYMBOL_GPL(ata_exec_command);

EXPORT_SYMBOL_GPL(ata_port_start);

EXPORT_SYMBOL_GPL(ata_sff_port_start);

EXPORT_SYMBOL_GPL(ata_interrupt);

EXPORT_SYMBOL_GPL(ata_do_set_mode);

EXPORT_SYMBOL_GPL(ata_data_xfer);

drivers/ata/libata-sff.c

+29 −8
Original line number Diff line number Diff line
@@ -80,25 +80,25 @@ u8 ata_dummy_irq_on (struct ata_port *ap) { return 0; } 
u8 ata_irq_ack(struct ata_port *ap, unsigned int chk_drq)

{

	unsigned int bits = chk_drq ? ATA_BUSY | ATA_DRQ : ATA_BUSY;

	u8 host_stat, post_stat, status;

	u8 host_stat = 0, post_stat = 0, status;



	status = ata_busy_wait(ap, bits, 1000);

	if (status & bits)

		if (ata_msg_err(ap))

			printk(KERN_ERR "abnormal status 0x%X\n", status);



	if (ap->ioaddr.bmdma_addr) {

		/* get controller status; clear intr, err bits */

		host_stat = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);

		iowrite8(host_stat | ATA_DMA_INTR | ATA_DMA_ERR,

			 ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);



		post_stat = ioread8(ap->ioaddr.bmdma_addr + ATA_DMA_STATUS);



	}

	if (ata_msg_intr(ap))

		printk(KERN_INFO "%s: irq ack: host_stat 0x%X, new host_stat 0x%X, drv_stat 0x%X\n",

			__FUNCTION__,

			host_stat, post_stat, status);



	return status;

}
@@ -516,6 +516,27 @@ void ata_bmdma_post_internal_cmd(struct ata_queued_cmd *qc) 
		ata_bmdma_stop(qc);

}



/**

 *	ata_sff_port_start - Set port up for dma.

 *	@ap: Port to initialize

 *

 *	Called just after data structures for each port are

 *	initialized.  Allocates space for PRD table if the device

 *	is DMA capable SFF.

 *

 *	May be used as the port_start() entry in ata_port_operations.

 *

 *	LOCKING:

 *	Inherited from caller.

 */



int ata_sff_port_start(struct ata_port *ap)

{

	if (ap->ioaddr.bmdma_addr)

		return ata_port_start(ap);

	return 0;

}



#ifdef CONFIG_PCI



static int ata_resources_present(struct pci_dev *pdev, int port)

include/linux/libata.h

+1 −0
Original line number Diff line number Diff line
@@ -753,6 +753,7 @@ extern u8 ata_check_status(struct ata_port *ap); 
extern u8 ata_altstatus(struct ata_port *ap);

extern void ata_exec_command(struct ata_port *ap, const struct ata_taskfile *tf);

extern int ata_port_start (struct ata_port *ap);

extern int ata_sff_port_start (struct ata_port *ap);

extern irqreturn_t ata_interrupt (int irq, void *dev_instance);

extern void ata_data_xfer(struct ata_device *adev, unsigned char *buf,

			  unsigned int buflen, int write_data);

CRA Git | Maintained and supported by SUSTech CRA and CCSE