Commit d913d3a7 authored Jun 28, 2016 by Samuel Gauthier Committed by David S. Miller Jun 29, 2016

openvswitch: fix conntrack netlink event delivery



Only the first and last netlink message for a particular conntrack are
actually sent. The first message is sent through nf_conntrack_confirm when
the conntrack is committed. The last one is sent when the conntrack is
destroyed on timeout. The other conntrack state change messages are not
advertised.

When the conntrack subsystem is used from netfilter, nf_conntrack_confirm
is called for each packet, from the postrouting hook, which in turn calls
nf_ct_deliver_cached_events to send the state change netlink messages.

This commit fixes the problem by calling nf_ct_deliver_cached_events in the
non-commit case as well.

Fixes: 7f8a436e ("openvswitch: Add conntrack action")
CC: Joe Stringer <joestringer@nicira.com>
CC: Justin Pettit <jpettit@nicira.com>
CC: Andy Zhou <azhou@nicira.com>
CC: Thomas Graf <tgraf@suug.ch>
Signed-off-by: Samuel Gauthier <samuel.gauthier@6wind.com>
Acked-by: Joe Stringer <joe@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 34c7bb47

net/openvswitch/conntrack.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -818,8 +818,18 @@ static int ovs_ct_lookup(struct net net, struct sw_flow_key key,
		*/
		state = OVS_CS_F_TRACKED \| OVS_CS_F_NEW \| OVS_CS_F_RELATED;
		__ovs_ct_update_key(key, state, &info->zone, exp->master);
		} else
		return __ovs_ct_lookup(net, key, info, skb);
		} else {
		struct nf_conn *ct;
		int err;

		err = __ovs_ct_lookup(net, key, info, skb);
		if (err)
		return err;

		ct = (struct nf_conn *)skb->nfct;
		if (ct)
		nf_ct_deliver_cached_events(ct);
		}

		return 0;
		}

Admin message