Commit d9012a59 authored Jul 30, 2020 by Chengming Zhou Committed by Jens Axboe Jul 30, 2020

iocost: Fix check condition of iocg abs_vdebt



We shouldn't skip iocg when its abs_vdebt is not zero.

Fixes: 0b80f986 ("iocost: protect iocg->abs_vdebt with iocg->waitq.lock")
Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0516c2f6

block/blk-iocost.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1370,7 +1370,7 @@ static void ioc_timer_fn(struct timer_list *timer)
		* should have woken up in the last period and expire idle iocgs.
		*/
		list_for_each_entry_safe(iocg, tiocg, &ioc->active_iocgs, active_list) {
		if (!waitqueue_active(&iocg->waitq) && iocg->abs_vdebt &&
		if (!waitqueue_active(&iocg->waitq) && !iocg->abs_vdebt &&
		!iocg_is_idle(iocg))
		continue;

Admin message