Commit d8fa4792 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Shawn Guo
Browse files

arm64: dts: imx8mq: correct interrupt flags 



GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW  = 1 = IRQ_TYPE_EDGE_RISING

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_LOW  => IRQ_TYPE_LEVEL_LOW

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Acked-By: default avatarTim Harvey <tharvey@gateworks.com>
Signed-off-by: default avatarShawn Guo <shawnguo@kernel.org>
parent 4153f781

arch/arm64/boot/dts/freescale/imx8mq-librem5-devkit.dts

+3 −2
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
/dts-v1/;



#include "dt-bindings/input/input.h"

#include <dt-bindings/interrupt-controller/irq.h>

#include "dt-bindings/pwm/pwm.h"

#include "dt-bindings/usb/pd.h"

#include "imx8mq.dtsi"
@@ -60,7 +61,7 @@ 
			label = "WWAN_WAKE";

			gpios = <&gpio3 8 GPIO_ACTIVE_LOW>;

			interrupt-parent = <&gpio3>;

			interrupts = <8 GPIO_ACTIVE_LOW>;

			interrupts = <8 IRQ_TYPE_LEVEL_LOW>;

			wakeup-source;

			linux,code = <KEY_PHONE>;

		};
@@ -288,7 +289,7 @@ 
		#clock-cells = <0>;

		clock-output-names = "pmic_clk";

		interrupt-parent = <&gpio1>;

		interrupts = <3 GPIO_ACTIVE_LOW>;

		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;

		rohm,reset-snvs-powered;



		regulators {

arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi

+2 −1
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
/dts-v1/;



#include "dt-bindings/input/input.h"

#include <dt-bindings/interrupt-controller/irq.h>

#include "dt-bindings/pwm/pwm.h"

#include "dt-bindings/usb/pd.h"

#include "imx8mq.dtsi"
@@ -640,7 +641,7 @@ 
		clock-names = "osc";

		clock-output-names = "pmic_clk";

		interrupt-parent = <&gpio1>;

		interrupts = <7 GPIO_ACTIVE_LOW>;

		interrupts = <7 IRQ_TYPE_LEVEL_LOW>;

		rohm,reset-snvs-powered;



		regulators {

arch/arm64/boot/dts/freescale/imx8mq-phanbell.dts

+2 −1
Original line number Diff line number Diff line
@@ -6,6 +6,7 @@ 
/dts-v1/;



#include "imx8mq.dtsi"

#include <dt-bindings/interrupt-controller/irq.h>



/ {

	model = "Google i.MX8MQ Phanbell";
@@ -125,7 +126,7 @@ 
		clocks = <&pmic_osc>;

		clock-output-names = "pmic_clk";

		interrupt-parent = <&gpio1>;

		interrupts = <3 GPIO_ACTIVE_LOW>;

		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;



		regulators {

			buck1: BUCK1 {

arch/arm64/boot/dts/freescale/imx8mq-pico-pi.dts

+2 −1
Original line number Diff line number Diff line
@@ -9,6 +9,7 @@ 
/dts-v1/;



#include "imx8mq.dtsi"

#include <dt-bindings/interrupt-controller/irq.h>



/ {

	model = "TechNexion PICO-PI-8M";
@@ -70,7 +71,7 @@ 
		clock-names = "osc";

		clock-output-names = "pmic_clk";

		interrupt-parent = <&gpio1>;

		interrupts = <3 GPIO_ACTIVE_LOW>;

		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;

		interrupt-names = "irq";



		regulators {

CRA Git | Maintained and supported by SUSTech CRA and CCSE