Commit d8f2799b authored May 04, 2012 by Stefan Metzmacher Committed by Steve French May 03, 2012

fs/cifs: fix parsing of dfs referrals



The problem was that the first referral was parsed more than once
and so the caller tried the same referrals multiple times.

The problem was introduced partly by commit
066ce689,
where 'ref += le16_to_cpu(ref->Size);' got lost,
but that was also wrong...

Cc: <stable@vger.kernel.org>
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Tested-by: Björn Jacke <bj@sernet.de>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Signed-off-by: Steve French <sfrench@us.ibm.com>

parent a557b976

fs/cifs/cifssmb.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -4844,8 +4844,12 @@ parse_DFS_referrals(TRANSACTION2_GET_DFS_REFER_RSP *pSMBr,
		max_len = data_end - temp;
		node->node_name = cifs_strndup_from_utf16(temp, max_len,
		is_unicode, nls_codepage);
		if (!node->node_name)
		if (!node->node_name) {
		rc = -ENOMEM;
		goto parse_DFS_referrals_exit;
		}

		ref++;
		}

		parse_DFS_referrals_exit:

Admin message