Commit d8ed75d5 authored Jun 10, 2016 by Tomasz Nowicki Committed by Bjorn Helgaas Jun 10, 2016

ARM64: PCI: ACPI support for legacy IRQs parsing and consolidation with DT code

To enable PCI legacy IRQs on platforms booting with ACPI, arch code should
include ACPI-specific callbacks that parse and set-up the device IRQ
number, equivalent to the DT boot path. Owing to the current ACPI core scan
handlers implementation, ACPI PCI legacy IRQs bindings cannot be parsed at
device add time, since that would trigger ACPI scan handlers ordering
issues depending on how the ACPI tables are defined.

To solve this problem and consolidate FW PCI legacy IRQs parsing in one
single pcibios callback (pending final removal), this patch moves DT PCI
IRQ parsing to the pcibios_alloc_irq() callback (called by PCI core code at
driver probe time) and adds ACPI PCI legacy IRQs parsing to the same
callback too, so that FW PCI legacy IRQs parsing is confined in one single
arch callback that can be easily removed when code parsing PCI legacy IRQs
is consolidated and moved to core PCI code.

Suggested-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Tomasz Nowicki <tn@semihalf.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 2ab51dde

arch/arm64/kernel/pci.c

+8 −3

Original line number	Diff line number	Diff line
		@@ -51,11 +51,16 @@ int pcibios_enable_device(struct pci_dev *dev, int mask)
		}

		/*
		* Try to assign the IRQ number from DT when adding a new device
		* Try to assign the IRQ number when probing a new device
		*/
		int pcibios_add_device(struct pci_dev *dev)
		int pcibios_alloc_irq(struct pci_dev *dev)
		{
		if (acpi_disabled)
		dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);
		#ifdef CONFIG_ACPI
		else
		return acpi_pci_irq_enable(dev);
		#endif

		return 0;
		}

Admin message