HID: fix oops in gyration_event() (d8e4ebf8) · Commits · 戴 / test

Fix oops caused by dereferencing field->hidinput in cases where the device hasn't been claimed by hid-input. Reported-by:

drivers/hid/hid-gyration.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -53,10 +53,13 @@ static int gyration_input_mapping(struct hid_device hdev, struct hid_input hi,
		static int gyration_event(struct hid_device hdev, struct hid_field field,
		struct hid_usage *usage, __s32 value)
		{
		struct input_dev *input = field->hidinput->input;

		if (!(hdev->claimed & HID_CLAIMED_INPUT) \|\| !field->hidinput)
		return 0;

		if ((usage->hid & HID_USAGE_PAGE) == HID_UP_GENDESK &&
		(usage->hid & 0xff) == 0x82) {
		struct input_dev *input = field->hidinput->input;
		input_event(input, usage->type, usage->code, 1);
		input_sync(input);
		input_event(input, usage->type, usage->code, 0);