Commit d8d9129e authored by Tejun Heo's avatar Tejun Heo Committed by Jeff Garzik
Browse files

libata: implement on-demand HPA unlocking 



Implement ata_scsi_unlock_native_capacity() which will be called
through SCSI layer when block layer notices that partitions on a
device extend beyond the end of the device.  It requests EH to unlock
HPA, waits for completion and returns the current device capacity.

This allows libata to unlock HPA on demand instead of having to decide
whether to unlock upfront.  Unlocking on demand is safer than
unlocking by upfront because some BIOSes write private data to the
area beyond HPA limit.  This was suggested by Ben Hutchings.

Signed-off-by: default avatarTejun Heo <tj@kernel.org>
Suggested-by: default avatarBen Hutchings <ben@decadent.org.uk>
Signed-off-by: default avatarJeff Garzik <jgarzik@redhat.com>
parent 68939ce5

drivers/ata/libata-core.c

+1 −0
Original line number Original line Diff line number Diff line
@@ -6668,6 +6668,7 @@ EXPORT_SYMBOL_GPL(ata_dummy_port_info); 
EXPORT_SYMBOL_GPL(ata_link_next);

EXPORT_SYMBOL_GPL(ata_link_next);

EXPORT_SYMBOL_GPL(ata_dev_next);

EXPORT_SYMBOL_GPL(ata_dev_next);

EXPORT_SYMBOL_GPL(ata_std_bios_param);

EXPORT_SYMBOL_GPL(ata_std_bios_param);

EXPORT_SYMBOL_GPL(ata_scsi_unlock_native_capacity);

EXPORT_SYMBOL_GPL(ata_host_init);

EXPORT_SYMBOL_GPL(ata_host_init);

EXPORT_SYMBOL_GPL(ata_host_alloc);

EXPORT_SYMBOL_GPL(ata_host_alloc);

EXPORT_SYMBOL_GPL(ata_host_alloc_pinfo);

EXPORT_SYMBOL_GPL(ata_host_alloc_pinfo);

drivers/ata/libata-scsi.c

+29 −0
Original line number Original line Diff line number Diff line
@@ -414,6 +414,35 @@ int ata_std_bios_param(struct scsi_device *sdev, struct block_device *bdev, 
	return 0;

	return 0;

}

}





/**

 *	ata_scsi_unlock_native_capacity - unlock native capacity

 *	@sdev: SCSI device to adjust device capacity for

 *

 *	This function is called if a partition on @sdev extends beyond

 *	the end of the device.  It requests EH to unlock HPA.

 *

 *	LOCKING:

 *	Defined by the SCSI layer.  Might sleep.

 */

void ata_scsi_unlock_native_capacity(struct scsi_device *sdev)

{

	struct ata_port *ap = ata_shost_to_port(sdev->host);

	struct ata_device *dev;

	unsigned long flags;



	spin_lock_irqsave(ap->lock, flags);



	dev = ata_scsi_find_dev(ap, sdev);

	if (dev && dev->n_sectors < dev->n_native_sectors) {

		dev->flags |= ATA_DFLAG_UNLOCK_HPA;

		dev->link->eh_info.action |= ATA_EH_RESET;

		ata_port_schedule_eh(ap);

	}



	spin_unlock_irqrestore(ap->lock, flags);

	ata_port_wait_eh(ap);

}



/**

/**

 *	ata_get_identity - Handler for HDIO_GET_IDENTITY ioctl

 *	ata_get_identity - Handler for HDIO_GET_IDENTITY ioctl

 *	@ap: target port

 *	@ap: target port

include/linux/libata.h

+2 −0
Original line number Original line Diff line number Diff line
@@ -1023,6 +1023,7 @@ extern void ata_scsi_simulate(struct ata_device *dev, struct scsi_cmnd *cmd, 
extern int ata_std_bios_param(struct scsi_device *sdev,

extern int ata_std_bios_param(struct scsi_device *sdev,

			      struct block_device *bdev,

			      struct block_device *bdev,

			      sector_t capacity, int geom[]);

			      sector_t capacity, int geom[]);

extern void ata_scsi_unlock_native_capacity(struct scsi_device *sdev);

extern int ata_scsi_slave_config(struct scsi_device *sdev);

extern int ata_scsi_slave_config(struct scsi_device *sdev);

extern void ata_scsi_slave_destroy(struct scsi_device *sdev);

extern void ata_scsi_slave_destroy(struct scsi_device *sdev);

extern int ata_scsi_change_queue_depth(struct scsi_device *sdev,

extern int ata_scsi_change_queue_depth(struct scsi_device *sdev,
@@ -1174,6 +1175,7 @@ extern struct device_attribute *ata_common_sdev_attrs[]; 
	.slave_configure	= ata_scsi_slave_config,	\

	.slave_configure	= ata_scsi_slave_config,	\

	.slave_destroy		= ata_scsi_slave_destroy,	\

	.slave_destroy		= ata_scsi_slave_destroy,	\

	.bios_param		= ata_std_bios_param,		\

	.bios_param		= ata_std_bios_param,		\

	.unlock_native_capacity	= ata_scsi_unlock_native_capacity, \

	.sdev_attrs		= ata_common_sdev_attrs

	.sdev_attrs		= ata_common_sdev_attrs





#define ATA_NCQ_SHT(drv_name)					\

#define ATA_NCQ_SHT(drv_name)					\

CRA Git | Maintained and supported by SUSTech CRA and CCSE