Commit d8d0b85b authored Aug 27, 2009 by Frank Filz Committed by J. Bruce Fields Aug 27, 2009

nfsd4: remove ACE4_IDENTIFIER_GROUP flag from GROUP@ entry

RFC 3530 says "ACE4_IDENTIFIER_GROUP flag MUST be ignored on entries
with these special identifiers. When encoding entries with these
special identifiers, the ACE4_IDENTIFIER_GROUP flag SHOULD be set to
zero." It really shouldn't matter either way, but the point is that
this flag is used to distinguish named users from named groups (since
unix allows a group to have the same name as a user), so it doesn't
really make sense to use it on a special identifier such as this.)

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

parent b0401d72

fs/nfsd/nfs4acl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -321,7 +321,7 @@ _posix_to_nfsv4_one(struct posix_acl pacl, struct nfs4_acl acl,
		deny = ~pas.group & pas.other;
		if (deny) {
		ace->type = NFS4_ACE_ACCESS_DENIED_ACE_TYPE;
		ace->flag = eflag \| NFS4_ACE_IDENTIFIER_GROUP;
		ace->flag = eflag;
		ace->access_mask = deny_mask_from_posix(deny, flags);
		ace->whotype = NFS4_ACL_WHO_GROUP;
		ace++;

Admin message