Commit d8bf368d authored by Valentin Rothberg's avatar Valentin Rothberg Committed by Ingo Molnar
Browse files

genirq: Remove the deprecated 'IRQF_DISABLED' request_irq() flag entirely 



The IRQF_DISABLED flag is a NOOP and has been scheduled for removal
since Linux v2.6.36 by commit 6932bf37 ("genirq: Remove
IRQF_DISABLED from core code").

According to commit e58aa3d2 ("genirq: Run irq handlers with
interrupts disabled"), running IRQ handlers with interrupts
enabled can cause stack overflows when the interrupt line of the
issuing device is still active.

This patch ends the grace period for IRQF_DISABLED (i.e.,
SA_INTERRUPT in older versions of Linux) and removes the
definition and all remaining usages of this flag.

There's still a few non-functional references left in the kernel
source:

  - The bigger hunk in Documentation/scsi/ncr53c8xx.txt is removed entirely
    as IRQF_DISABLED is gone now; the usage in older kernel versions
    (including the old SA_INTERRUPT flag) should be discouraged.  The
    trouble of using IRQF_SHARED is a general problem and not specific to
    any driver.

  - I left the reference in Documentation/PCI/MSI-HOWTO.txt untouched since
    it has already been removed in linux-next.

  - All remaining references are changelogs that I suggest to keep.

Signed-off-by: default avatarValentin Rothberg <valentinrothberg@gmail.com>
Cc: Afzal Mohammed <afzal@ti.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Brian Norris <computersforpeace@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Ewan Milne <emilne@redhat.com>
Cc: Eyal Perry <eyalpe@mellanox.com>
Cc: Felipe Balbi <balbi@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Hongliang Tao <taohl@lemote.com>
Cc: Huacai Chen <chenhc@lemote.com>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Keerthy <j-keerthy@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: Paul Bolle <pebolle@tiscali.nl>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Rajendra Nayak <rnayak@ti.com>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: Sricharan R <r.sricharan@ti.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tony Lindgren <tony@atomide.com>
Cc: Zhou Wang <wangzhou1@hisilicon.com>
Cc: iss_storagedev@hp.com
Cc: linux-mips@linux-mips.org
Cc: linux-mtd@lists.infradead.org
Link: http://lkml.kernel.org/r/1425565425-12604-1-git-send-email-valentinrothberg@gmail.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 33ca8a53

Documentation/scsi/ncr53c8xx.txt

+0 −25
Original line number Diff line number Diff line
@@ -786,7 +786,6 @@ port address 0x1400. 
        irqm:1     same as initial settings (assumed BIOS settings)

        irqm:2     always totem pole

        irqm:0x10  driver will not use IRQF_SHARED flag when requesting irq

        irqm:0x20  driver will not use IRQF_DISABLED flag when requesting irq



    (Bits 0x10 and 0x20 can be combined with hardware irq mode option)
@@ -1231,30 +1230,6 @@ they only refer to system buffers that are well aligned. So, a work around 
may only be needed under Linux when a scatter/gather list is not used and 

when the SCSI DATA IN phase is reentered after a phase mismatch.



14.5 IRQ sharing problems



When an IRQ is shared by devices that are handled by different drivers, it 

may happen that one driver complains about the request of the IRQ having 

failed. Inder Linux-2.0, this may be due to one driver having requested the 

IRQ using the IRQF_DISABLED flag but some other having requested the same IRQ

without this flag. Under both Linux-2.0 and linux-2.2, this may be caused by 

one driver not having requested the IRQ with the IRQF_SHARED flag.



By default, the ncr53c8xx and sym53c8xx drivers request IRQs with both the 

IRQF_DISABLED and the IRQF_SHARED flag under Linux-2.0 and with only the IRQF_SHARED

flag under Linux-2.2.



Under Linux-2.0, you can disable use of IRQF_DISABLED flag from the boot

command line by using the following option:



     ncr53c8xx=irqm:0x20   (for the generic ncr53c8xx driver)

     sym53c8xx=irqm:0x20   (for the sym53c8xx driver)



If this does not fix the problem, then you may want to check how all other 

drivers are requesting the IRQ and report the problem. Note that if at least 

a single driver does not request the IRQ with the IRQF_SHARED flag (share IRQ),

then the request of the IRQ obviously will not succeed for all the drivers.



15. SCSI problem troubleshooting



15.1 Problem tracking

Documentation/scsi/tmscsim.txt

+0 −4
Original line number Diff line number Diff line
@@ -107,10 +107,6 @@ produced errors and started to corrupt my disks. So don't do that! A 37.50 
MHz PCI bus works for me, though, but I don't recommend using higher clocks

than the 33.33 MHz being in the PCI spec.



If you want to share the IRQ with another device and the driver refuses to

do so, you might succeed with changing the DC390_IRQ type in tmscsim.c to 

IRQF_SHARED | IRQF_DISABLED.





3.Features

----------

arch/mips/loongson/loongson-3/hpet.c

+1 −1
Original line number Diff line number Diff line
@@ -162,7 +162,7 @@ static irqreturn_t hpet_irq_handler(int irq, void *data) 


static struct irqaction hpet_irq = {

	.handler = hpet_irq_handler,

	.flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,

	.flags = IRQF_NOBALANCING | IRQF_TIMER,

	.name = "hpet",

};

drivers/block/cpqarray.c

+2 −2
Original line number Diff line number Diff line
@@ -405,8 +405,8 @@ static int cpqarray_register_ctlr(int i, struct pci_dev *pdev) 
		goto Enomem4;

	}

	hba[i]->access.set_intr_mask(hba[i], 0);

	if (request_irq(hba[i]->intr, do_ida_intr,

		IRQF_DISABLED|IRQF_SHARED, hba[i]->devname, hba[i]))

	if (request_irq(hba[i]->intr, do_ida_intr, IRQF_SHARED,

			hba[i]->devname, hba[i]))

	{

		printk(KERN_ERR "cpqarray: Unable to get irq %d for %s\n",

				hba[i]->intr, hba[i]->devname);

drivers/bus/omap_l3_noc.c

+2 −2
Original line number Diff line number Diff line
@@ -284,7 +284,7 @@ static int omap_l3_probe(struct platform_device *pdev) 
	 */

	l3->debug_irq = platform_get_irq(pdev, 0);

	ret = devm_request_irq(l3->dev, l3->debug_irq, l3_interrupt_handler,

			       IRQF_DISABLED, "l3-dbg-irq", l3);

			       0x0, "l3-dbg-irq", l3);

	if (ret) {

		dev_err(l3->dev, "request_irq failed for %d\n",

			l3->debug_irq);
@@ -293,7 +293,7 @@ static int omap_l3_probe(struct platform_device *pdev) 


	l3->app_irq = platform_get_irq(pdev, 1);

	ret = devm_request_irq(l3->dev, l3->app_irq, l3_interrupt_handler,

			       IRQF_DISABLED, "l3-app-irq", l3);

			       0x0, "l3-app-irq", l3);

	if (ret)

		dev_err(l3->dev, "request_irq failed for %d\n", l3->app_irq);

CRA Git | Maintained and supported by SUSTech CRA and CCSE