Commit d8bd8c6e authored May 22, 2020 by Ard Biesheuvel

efi/efivars: Add missing kobject_put() in sysfs entry creation error path



The documentation provided by kobject_init_and_add() clearly spells out
the need to call kobject_put() on the kobject if an error is returned.
Add this missing call to the error path.

Cc: <stable@vger.kernel.org>
Reported-by: 亿一 <teroincn@gmail.com>
Signed-off-by: Ard Biesheuvel <ardb@kernel.org>

parent 27cd5511

drivers/firmware/efi/efivars.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -522,8 +522,10 @@ efivar_create_sysfs_entry(struct efivar_entry *new_var)
		ret = kobject_init_and_add(&new_var->kobj, &efivar_ktype,
		NULL, "%s", short_name);
		kfree(short_name);
		if (ret)
		if (ret) {
		kobject_put(&new_var->kobj);
		return ret;
		}

		kobject_uevent(&new_var->kobj, KOBJ_ADD);
		if (efivar_entry_add(new_var, &efivar_sysfs_list)) {

Admin message