Commit d8aec3db authored Mar 26, 2012 by Elric Fu Committed by Sarah Sharp Apr 11, 2012

USB: fix bug of device descriptor got from superspeed device



When the Seagate Goflex USB3.0 device is attached to VIA xHCI
host, sometimes the device will downgrade mode to high speed.
By the USB analyzer, I found the device finished the link
training process and worked at superspeed mode. But the device
descriptor got from the device shows the device works at 2.1.
It is very strange and seems like the device controller of
Seagate Goflex has a little confusion.

The first 8 bytes of device descriptor should be:
12 01 00 03 00 00 00 09

But the first 8 bytes of wrong device descriptor are:
12 01 10 02 00 00 00 40

The wrong device descriptor caused the initialization of mass
storage failed. After a while, the device would be recognized
as a high speed device and works fine.

This patch will warm reset the device to fix the issue after
finding the bcdUSB field of device descriptor isn't 0x0300
but the speed mode of device is superspeed.

This patch should be backported to kernels as old as 3.2, or ones that
contain the commit 75d7cf72 "usbcore:
refine warm reset logic".

Signed-off-by: Elric Fu <elricfu1@gmail.com>
Acked-by: Andiry Xu <Andiry.Xu@amd.com>
Acked-by: Sergei Shtylyov <sshtylyov@mvista.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Cc: stable@vger.kernel.org

parent c7713e73

drivers/usb/core/hub.c

+16 −0

Original line number	Original line	Diff line number	Diff line
	@@ -3163,6 +3163,22 @@ hub_port_init (struct usb_hub hub, struct usb_device udev, int port1,
	if (retval)		if (retval)
	goto fail;		goto fail;

			/*
			* Some superspeed devices have finished the link training process
			* and attached to a superspeed hub port, but the device descriptor
			* got from those devices show they aren't superspeed devices. Warm
			* reset the port attached by the devices can fix them.
			*/
			if ((udev->speed == USB_SPEED_SUPER) &&
			(le16_to_cpu(udev->descriptor.bcdUSB) < 0x0300)) {
			dev_err(&udev->dev, "got a wrong device descriptor, "
			"warm reset device\n");
			hub_port_reset(hub, port1, udev,
			HUB_BH_RESET_TIME, true);
			retval = -EINVAL;
			goto fail;
			}

	if (udev->descriptor.bMaxPacketSize0 == 0xff \|\|		if (udev->descriptor.bMaxPacketSize0 == 0xff \|\|
	udev->speed == USB_SPEED_SUPER)		udev->speed == USB_SPEED_SUPER)
	i = 512;		i = 512;

Admin message