pinctrl: stm32: don't print an error on probe deferral during clock get (d888229e) · Commits · 戴 / test

Change STM32 pinctrl driver to not print an error trace when probe is deferred due to clock resource. Probe defer issue (for clocks) could occur during bank registering when some banks have already been registered. In this case banks already registered should be released. To not waste time in this case, it is better to check first if all clocks are available before registering banks. Signed-off-by:

Etienne Carriere <etienne.carriere@st.com> Signed-off-by:

Alexandre Torgue <alexandre.torgue@st.com> Link: https://lore.kernel.org/r/20200615125407.27632-2-alexandre.torgue@st.com Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/pinctrl/stm32/pinctrl-stm32.c

+17 −6

Original line number	Diff line number	Diff line
		@@ -1217,12 +1217,6 @@ static int stm32_gpiolib_register_bank(struct stm32_pinctrl *pctl,
		if (IS_ERR(bank->base))
		return PTR_ERR(bank->base);

		bank->clk = of_clk_get_by_name(np, NULL);
		if (IS_ERR(bank->clk)) {
		dev_err(dev, "failed to get clk (%ld)\n", PTR_ERR(bank->clk));
		return PTR_ERR(bank->clk);
		}

		err = clk_prepare(bank->clk);
		if (err) {
		dev_err(dev, "failed to prepare clk (%d)\n", err);
		@@ -1517,6 +1511,23 @@ int stm32_pctl_probe(struct platform_device *pdev)
		if (!pctl->banks)
		return -ENOMEM;

		i = 0;
		for_each_available_child_of_node(np, child) {
		struct stm32_gpio_bank *bank = &pctl->banks[i];

		if (of_property_read_bool(child, "gpio-controller")) {
		bank->clk = of_clk_get_by_name(child, NULL);
		if (IS_ERR(bank->clk)) {
		if (PTR_ERR(bank->clk) != -EPROBE_DEFER)
		dev_err(dev,
		"failed to get clk (%ld)\n",
		PTR_ERR(bank->clk));
		return PTR_ERR(bank->clk);
		}
		i++;
		}
		}

		for_each_available_child_of_node(np, child) {
		if (of_property_read_bool(child, "gpio-controller")) {
		ret = stm32_gpiolib_register_bank(pctl, child);

Admin message