Commit d85de339 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

kconfig: qconf: fix signal connection to invalid slots 



If you right-click in the ConfigList window, you will see the following
messages in the console:

QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:888
QObject::connect:  (sender name:   'config')
QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:897
QObject::connect:  (sender name:   'config')
QObject::connect: No such slot QAction::setOn(bool) in scripts/kconfig/qconf.cc:906
QObject::connect:  (sender name:   'config')

Right, there is no such slot in QAction. I think this is a typo of
setChecked.

Due to this bug, when you toggled the menu "Option->Show Name/Range/Data"
the state of the context menu was not previously updated. Fix this.

Fixes: d5d973c3 ("Port xconfig to Qt5 - Put back some of the old implementation(part 2)")
Signed-off-by: default avatarMasahiro Yamada <masahiroy@kernel.org>
parent e29a6d63

scripts/kconfig/qconf.cc

+4 −4
Original line number Diff line number Diff line
@@ -885,7 +885,7 @@ void ConfigList::contextMenuEvent(QContextMenuEvent *e) 
		connect(action, SIGNAL(toggled(bool)),

			parent(), SLOT(setShowName(bool)));

		connect(parent(), SIGNAL(showNameChanged(bool)),

			action, SLOT(setOn(bool)));

			action, SLOT(setChecked(bool)));

		action->setChecked(showName);

		headerPopup->addAction(action);
@@ -894,7 +894,7 @@ void ConfigList::contextMenuEvent(QContextMenuEvent *e) 
		connect(action, SIGNAL(toggled(bool)),

			parent(), SLOT(setShowRange(bool)));

		connect(parent(), SIGNAL(showRangeChanged(bool)),

			action, SLOT(setOn(bool)));

			action, SLOT(setChecked(bool)));

		action->setChecked(showRange);

		headerPopup->addAction(action);
@@ -903,7 +903,7 @@ void ConfigList::contextMenuEvent(QContextMenuEvent *e) 
		connect(action, SIGNAL(toggled(bool)),

			parent(), SLOT(setShowData(bool)));

		connect(parent(), SIGNAL(showDataChanged(bool)),

			action, SLOT(setOn(bool)));

			action, SLOT(setChecked(bool)));

		action->setChecked(showData);

		headerPopup->addAction(action);

	}
@@ -1275,7 +1275,7 @@ QMenu* ConfigInfoView::createStandardContextMenu(const QPoint & pos) 


	action->setCheckable(true);

	connect(action, SIGNAL(toggled(bool)), SLOT(setShowDebug(bool)));

	connect(this, SIGNAL(showDebugChanged(bool)), action, SLOT(setOn(bool)));

	connect(this, SIGNAL(showDebugChanged(bool)), action, SLOT(setChecked(bool)));

	action->setChecked(showDebug());

	popup->addSeparator();

	popup->addAction(action);

CRA Git | Maintained and supported by SUSTech CRA and CCSE