Commit d8590430 authored Nov 19, 2018 by Jiri Olsa Committed by Arnaldo Carvalho de Melo Dec 17, 2018

perf top: Display slow reader warning when droping samples



Currently we display the "Too slow to read ring buffer.." helpline only
in the slow reader thread. This patch triggers it also when the
processing thread drops samples, because it has the same reason, which
is too many data on input.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Acked-by: David S. Miller <davem@davemloft.net>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lkml.kernel.org/n/tip-bnev2mloavyurmgchcr3o24o@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 97f7e0b3

tools/perf/builtin-top.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -571,7 +571,7 @@ static void perf_top__sort_new_samples(void *arg)
		hists__collapse_resort(hists, NULL);
		perf_evsel__output_resort(evsel, NULL);

		if (t->lost)
		if (t->lost \|\| t->drop)
		pr_warning("Too slow to read ring buffer (change period (-c/-F) or limit CPUs (-C)\n");

		perf_top__reset_sample_counters(t);

Admin message