gpio: xgene-sb: Drop extra check to call acpi_gpiochip_request_interrupts() (d850c6f4) · Commits · 戴 / test

There is no need to have an additional check to call acpi_gpiochip_request_interrupts(). Even without any interrupts available the registered ACPI Event handlers can be useful for debugging purposes. Signed-off-by:

Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20200512182721.55127-3-andriy.shevchenko@linux.intel.com Signed-off-by:

Linus Walleij <linus.walleij@linaro.org>

drivers/gpio/gpio-xgene-sb.c

+3 −7

Original line number	Diff line number	Diff line
		@@ -290,10 +290,8 @@ static int xgene_gpio_sb_probe(struct platform_device *pdev)

		dev_info(&pdev->dev, "X-Gene GPIO Standby driver registered\n");

		if (priv->nirq > 0) {
		/* Register interrupt handlers for gpio signaled acpi events */
		/* Register interrupt handlers for GPIO signaled ACPI Events */
		acpi_gpiochip_request_interrupts(&priv->gc);
		}

		return ret;
		}
		@@ -302,9 +300,7 @@ static int xgene_gpio_sb_remove(struct platform_device *pdev)
		{
		struct xgene_gpio_sb *priv = platform_get_drvdata(pdev);

		if (priv->nirq > 0) {
		acpi_gpiochip_free_interrupts(&priv->gc);
		}

		irq_domain_remove(priv->irq_domain);

Admin message