Commit d82c3682 authored Dec 18, 2017 by Miquel Raynal Committed by Richard Weinberger Dec 18, 2017

mtd: Fix mtd_check_oob_ops()



The mtd_check_oob_ops() helper verifies if the operation defined by the
user is correct.

Fix the check that verifies if the entire requested area exists. This
check is too restrictive and will fail anytime the last data byte of the
very last page is included in an operation.

Fixes: 5cdd929d ("mtd: Add sanity checks in mtd_write/read_oob()")
Signed-off-by: Miquel Raynal <miquel.raynal@free-electrons.com>
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Signed-off-by: Richard Weinberger <richard@nod.at>

parent 9ec4c8e8

drivers/mtd/mtdcore.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1114,7 +1114,7 @@ static int mtd_check_oob_ops(struct mtd_info *mtd, loff_t offs,
		if (!ops->oobbuf)
		ops->ooblen = 0;

		if (offs < 0 \|\| offs + ops->len >= mtd->size)
		if (offs < 0 \|\| offs + ops->len > mtd->size)
		return -EINVAL;

		if (ops->ooblen) {

Admin message