Commit d80c0d14 authored by Reinhard Speyerer's avatar Reinhard Speyerer Committed by Johan Hovold
Browse files

USB: qcserial/option: make AT URCs work for Sierra Wireless MC73xx 

As has been discussed in the thread starting with
https://lkml.kernel.org/g/549748e9.d+SiJzqu50f1r4lSAL043YSc@arcor.de


Sierra Wireless MC73xx devices with USB VID/PID 0x1199:0x68c0 require the
option_send_setup() code to be used on the USB interface for the AT port
to make unsolicited response codes work correctly. Move these devices from
the qcserial driver where they have been added by commit
70a3615f ("usb: qcserial: add Sierra Wireless
MC73xx") to the option driver and add a MC73xx-specific blacklist
to ensure that
1. the sendsetup code is not used for the DIAG/DM and NMEA interfaces
2. the option driver does not attach to the QMI/network interfaces

Signed-off-by: default avatarReinhard Speyerer <rspmn@arcor.de>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
parent 1ae78a48

drivers/usb/serial/option.c

+10 −1
Original line number Diff line number Diff line
@@ -234,6 +234,8 @@ static void option_instat_callback(struct urb *urb); 


#define QUALCOMM_VENDOR_ID			0x05C6



#define SIERRA_VENDOR_ID			0x1199



#define CMOTECH_VENDOR_ID			0x16d8

#define CMOTECH_PRODUCT_6001			0x6001

#define CMOTECH_PRODUCT_CMU_300			0x6002
@@ -512,7 +514,7 @@ enum option_blacklist_reason { 
		OPTION_BLACKLIST_RESERVED_IF = 2

};



#define MAX_BL_NUM  8

#define MAX_BL_NUM  11

struct option_blacklist_info {

	/* bitfield of interface numbers for OPTION_BLACKLIST_SENDSETUP */

	const unsigned long sendsetup;
@@ -601,6 +603,11 @@ static const struct option_blacklist_info telit_le920_blacklist = { 
	.reserved = BIT(1) | BIT(5),

};



static const struct option_blacklist_info sierra_mc73xx_blacklist = {

	.sendsetup = BIT(0) | BIT(2),

	.reserved = BIT(8) | BIT(10) | BIT(11),

};



static const struct usb_device_id option_ids[] = {

	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },

	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
@@ -1098,6 +1105,8 @@ static const struct usb_device_id option_ids[] = { 
	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x6613)}, /* Onda H600/ZTE MF330 */

	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x0023)}, /* ONYX 3G device */

	{ USB_DEVICE(QUALCOMM_VENDOR_ID, 0x9000)}, /* SIMCom SIM5218 */

	{ USB_DEVICE_INTERFACE_CLASS(SIERRA_VENDOR_ID, 0x68c0, 0xff),

	  .driver_info = (kernel_ulong_t)&sierra_mc73xx_blacklist }, /* MC73xx */

	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6001) },

	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_CMU_300) },

	{ USB_DEVICE(CMOTECH_VENDOR_ID, CMOTECH_PRODUCT_6003),

drivers/usb/serial/qcserial.c

+0 −1
Original line number Diff line number Diff line
@@ -142,7 +142,6 @@ static const struct usb_device_id id_table[] = { 
	{DEVICE_SWI(0x0f3d, 0x68a2)},	/* Sierra Wireless MC7700 */

	{DEVICE_SWI(0x114f, 0x68a2)},	/* Sierra Wireless MC7750 */

	{DEVICE_SWI(0x1199, 0x68a2)},	/* Sierra Wireless MC7710 */

	{DEVICE_SWI(0x1199, 0x68c0)},	/* Sierra Wireless MC73xx */

	{DEVICE_SWI(0x1199, 0x901c)},	/* Sierra Wireless EM7700 */

	{DEVICE_SWI(0x1199, 0x901f)},	/* Sierra Wireless EM7355 */

	{DEVICE_SWI(0x1199, 0x9040)},	/* Sierra Wireless Modem */

CRA Git | Maintained and supported by SUSTech CRA and CCSE