Commit d80bb3f9 authored May 18, 2018 by Liu Bo Committed by David Sterba May 30, 2018

Btrfs: remove always true check in unlock_up



As unlock_up() is written as

for () {
   if (!path->locks[i])
       break;
   ...
   if (... && path->locks[i]) {
   }
}

Apparently, @path->locks[i] is always true at this 'if'.

Signed-off-by: Liu Bo <bo.liu@linux.alibaba.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 662c653b

fs/btrfs/ctree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2330,7 +2330,7 @@ static noinline void unlock_up(struct btrfs_path *path, int level,
		no_skips = 1;

		t = path->nodes[i];
		if (i >= lowest_unlock && i > skip_level && path->locks[i]) {
		if (i >= lowest_unlock && i > skip_level) {
		btrfs_tree_unlock_rw(t, path->locks[i]);
		path->locks[i] = 0;
		if (write_lock_level &&

Admin message