Commit d80865bf authored Aug 17, 2018 by Chengguang Xu Committed by Ilya Dryomov Jan 27, 2020

ceph: remove unnecessary assignment in ceph_pre_init_acls()



ceph_pagelist_encode_string() will not fail in reserved case,
also, we do not check err code here, so remove unnecessary
assignment.

Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
Reviewed-by: "Yan, Zheng" <zyan@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

parent 8f5ac172

fs/ceph/acl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -222,7 +222,7 @@ int ceph_pre_init_acls(struct inode dir, umode_t mode,
		err = ceph_pagelist_reserve(pagelist, len + val_size2 + 8);
		if (err)
		goto out_err;
		err = ceph_pagelist_encode_string(pagelist,
		ceph_pagelist_encode_string(pagelist,
		XATTR_NAME_POSIX_ACL_DEFAULT, len);
		err = posix_acl_to_xattr(&init_user_ns, default_acl,
		tmp_buf, val_size2);

Admin message