pcmcia: remove useless msleep in ds.c (d801c140) · Commits · 戴 / test

As this is the socket thread (pccardd) starting up, we do not have anything to wait for in ds.c. Instead, wait the same amount of time in pccardd to allow userspace to catch up and - possibly - execute pcmcia-socket-startup. Signed-off-by:

Dominik Brodowski <linux@dominikbrodowski.net>

drivers/pcmcia/cs.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -689,6 +689,9 @@ static int pccardd(void *__skt)

		complete(&skt->thread_done);

		/* wait for userspace to catch up */
		msleep(250);

		set_freezable();
		for (;;) {
		unsigned long flags;

drivers/pcmcia/ds.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1356,12 +1356,6 @@ static int __devinit pcmcia_bus_add_socket(struct device *dev,
		return -ENODEV;
		}

		/*
		* Ugly. But we want to wait for the socket threads to have started up.
		* We really should let the drivers themselves drive some of this..
		*/
		msleep(250);

		ret = sysfs_create_bin_file(&dev->kobj, &pccard_cis_attr);
		if (ret) {
		dev_printk(KERN_ERR, dev, "PCMCIA registration failed\n");

Admin message