Commit d7fbefe0 authored Sep 13, 2006 by Sascha Hauer Committed by Mauro Carvalho Chehab Sep 26, 2006

V4L/DVB (4627): Vivi crashes with mplayer



The vivi.current_norm field is not initialized in vivi.c, so a
VIDIOC_G_STD ioctl without a prior call to VIDIOC_S_STD gives
unpredictable results. mplayer does exactly this.

Signed-off-by Sascha Hauer <s.hauer@pengutronix.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>

parent 183d896a

drivers/media/video/vivi.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1360,6 +1360,8 @@ static int __init vivi_init(void)
		dev->vidq.timeout.data = (unsigned long)dev;
		init_timer(&dev->vidq.timeout);

		vivi.current_norm = tvnorms[0].id;

		ret = video_register_device(&vivi, VFL_TYPE_GRABBER, video_nr);
		printk(KERN_INFO "Video Technology Magazine Virtual Video Capture Board (Load status: %d)\n", ret);
		return ret;

Admin message