Commit d7f84244 authored Oct 25, 2016 by Emmanuel Grumbach Committed by Johannes Berg Jan 11, 2017

mac80211: fix the TID on NDPs sent as EOSP carrier



In the commit below, I forgot to translate the mac80211's
AC to QoS IE order. Moreover, the condition in the if was
wrong. Fix both issues.
This bug would hit only with clients that didn't set all
the ACs as delivery enabled.

Fixes: f438ceb8 ("mac80211: uapsd_queues is in QoS IE order")
Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

parent c38c39bf

net/mac80211/sta_info.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1501,8 +1501,8 @@ ieee80211_sta_ps_deliver_response(struct sta_info *sta,

		/* This will evaluate to 1, 3, 5 or 7. */
		for (ac = IEEE80211_AC_VO; ac < IEEE80211_NUM_ACS; ac++)
		if (ignored_acs & BIT(ac))
		continue;
		if (!(ignored_acs & ieee80211_ac_to_qos_mask[ac]))
		break;
		tid = 7 - 2 * ac;

		ieee80211_send_null_response(sta, tid, reason, true, false);

Admin message