Commit d7f7e001 authored Nov 29, 2018 by Baruch Siach Committed by David S. Miller Nov 29, 2018

net: phy: sfp: correct store of detected link modes



The link modes that sfp_parse_support() detects are stored in the
'modes' bitmap. There is no reason to make an exception for 1000Base-PX
or 1000Base-BX10.

Fixes: 03145864 ("sfp: support 1G BiDi (eg, FiberStore SFP-GE-BX) modules")
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Acked-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f1c0f591

drivers/net/phy/sfp-bus.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -162,7 +162,7 @@ void sfp_parse_support(struct sfp_bus bus, const struct sfp_eeprom_id id,
		/* 1000Base-PX or 1000Base-BX10 */
		if ((id->base.e_base_px \|\| id->base.e_base_bx10) &&
		br_min <= 1300 && br_max >= 1200)
		phylink_set(support, 1000baseX_Full);
		phylink_set(modes, 1000baseX_Full);

		/* For active or passive cables, select the link modes
		* based on the bit rates and the cable compliance bytes.

Admin message