Unverified Commit d7c7fc44 authored Nov 20, 2018 by Marek Szyprowski Committed by Mark Brown Nov 20, 2018

regulator: s2mps11: Fix GPIO descriptor initialization

GPIO descriptor array must be zero initialized to ensure that core will
properly handle also the case when no external GPIO pin is defined.

Fixes: 1c984942 ("regulator: s2mps11: Pass descriptor instead of GPIO number")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent ffb8c1e4

drivers/regulator/s2mps11.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -1134,9 +1134,8 @@ static int s2mps11_pmic_probe(struct platform_device *pdev)
		return -EINVAL;
		}

		s2mps11->ext_control_gpiod = devm_kmalloc_array(&pdev->dev,
		rdev_num, sizeof(*s2mps11->ext_control_gpiod),
		GFP_KERNEL);
		s2mps11->ext_control_gpiod = devm_kcalloc(&pdev->dev, rdev_num,
		sizeof(*s2mps11->ext_control_gpiod), GFP_KERNEL);
		if (!s2mps11->ext_control_gpiod)
		return -ENOMEM;