Commit d7bc63fa authored Sep 28, 2020 by Maulik Shah Committed by Marc Zyngier Oct 06, 2020

irqchip/qcom-pdc: Reset PDC interrupts during init



Kexec can directly boot into a new kernel without going to complete
reboot. This can leave the previous kernel's configuration for PDC
interrupts as is.

Clear previous kernel's configuration during init by setting interrupts
in enable bank to zero. The IRQs specified in qcom,pdc-ranges property
are the only ones that can be used by the new kernel so clear only those
IRQs. The remaining ones may be in use by a different kernel and should
not be set by new kernel.

Suggested-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Tested-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Link: https://lore.kernel.org/r/1601267524-20199-7-git-send-email-mkshah@codeaurora.org

parent 299d7890

drivers/irqchip/qcom-pdc.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -341,7 +341,8 @@ static const struct irq_domain_ops qcom_pdc_gpio_ops = {

		static int pdc_setup_pin_mapping(struct device_node *np)
		{
		int ret, n;
		int ret, n, i;
		u32 irq_index, reg_index, val;

		n = of_property_count_elems_of_size(np, "qcom,pdc-ranges", sizeof(u32));
		if (n <= 0 \|\| n % 3)
		@@ -370,6 +371,14 @@ static int pdc_setup_pin_mapping(struct device_node *np)
		&pdc_region[n].cnt);
		if (ret)
		return ret;

		for (i = 0; i < pdc_region[n].cnt; i++) {
		reg_index = (i + pdc_region[n].pin_base) >> 5;
		irq_index = (i + pdc_region[n].pin_base) & 0x1f;
		val = pdc_reg_read(IRQ_ENABLE_BANK, reg_index);
		val &= ~BIT(irq_index);
		pdc_reg_write(IRQ_ENABLE_BANK, reg_index, val);
		}
		}

		return 0;

Admin message