Commit d7b259fe authored by Larry Finger's avatar Larry Finger Committed by Kalle Valo
Browse files

rtlwifi: rtl8723be: Convert macros that set descriptor 



As a first step in the conversion, the macros that set the RX and TX
descriptors are converted to static inline routines, and the names are
changed from upper to lower case. To minimize the changes in a given
step, the input descriptor information is left as as a byte array
(u8 *), even though it should be a little-endian word array (__le32 *).
That will be changed in the next patch.

Several places where checkpatch.pl complains about a space after a cast
are fixed.

Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent 360226fd

drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.c

+102 −102
Original line number Diff line number Diff line
@@ -247,7 +247,7 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
	u32 dwtmp = 0;

	memset(virtualaddress, 0, 8);



	SET_EARLYMODE_PKTNUM(virtualaddress, ptcb_desc->empkt_num);

	set_earlymode_pktnum(virtualaddress, ptcb_desc->empkt_num);

	if (ptcb_desc->empkt_num == 1) {

		dwtmp = ptcb_desc->empkt_len[0];

	} else {
@@ -255,7 +255,7 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
		dwtmp += ((dwtmp % 4) ? (4 - dwtmp % 4) : 0) + 4;

		dwtmp += ptcb_desc->empkt_len[1];

	}

	SET_EARLYMODE_LEN0(virtualaddress, dwtmp);

	set_earlymode_len0(virtualaddress, dwtmp);



	if (ptcb_desc->empkt_num <= 3) {

		dwtmp = ptcb_desc->empkt_len[2];
@@ -264,7 +264,7 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
		dwtmp += ((dwtmp % 4) ? (4 - dwtmp % 4) : 0) + 4;

		dwtmp += ptcb_desc->empkt_len[3];

	}

	SET_EARLYMODE_LEN1(virtualaddress, dwtmp);

	set_earlymode_len1(virtualaddress, dwtmp);

	if (ptcb_desc->empkt_num <= 5) {

		dwtmp = ptcb_desc->empkt_len[4];

	} else {
@@ -272,8 +272,8 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
		dwtmp += ((dwtmp % 4) ? (4 - dwtmp % 4) : 0) + 4;

		dwtmp += ptcb_desc->empkt_len[5];

	}

	SET_EARLYMODE_LEN2_1(virtualaddress, dwtmp & 0xF);

	SET_EARLYMODE_LEN2_2(virtualaddress, dwtmp >> 4);

	set_earlymode_len2_1(virtualaddress, dwtmp & 0xF);

	set_earlymode_len2_2(virtualaddress, dwtmp >> 4);

	if (ptcb_desc->empkt_num <= 7) {

		dwtmp = ptcb_desc->empkt_len[6];

	} else {
@@ -281,7 +281,7 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
		dwtmp += ((dwtmp % 4) ? (4 - dwtmp % 4) : 0) + 4;

		dwtmp += ptcb_desc->empkt_len[7];

	}

	SET_EARLYMODE_LEN3(virtualaddress, dwtmp);

	set_earlymode_len3(virtualaddress, dwtmp);

	if (ptcb_desc->empkt_num <= 9) {

		dwtmp = ptcb_desc->empkt_len[8];

	} else {
@@ -289,7 +289,7 @@ static void _rtl8723be_insert_emcontent(struct rtl_tcb_desc *ptcb_desc, 
		dwtmp += ((dwtmp % 4) ? (4 - dwtmp % 4) : 0) + 4;

		dwtmp += ptcb_desc->empkt_len[9];

	}

	SET_EARLYMODE_LEN4(virtualaddress, dwtmp);

	set_earlymode_len4(virtualaddress, dwtmp);

}



bool rtl8723be_rx_query_desc(struct ieee80211_hw *hw,
@@ -301,39 +301,39 @@ bool rtl8723be_rx_query_desc(struct ieee80211_hw *hw, 
	struct rx_fwinfo_8723be *p_drvinfo;

	struct ieee80211_hdr *hdr;

	u8 wake_match;

	u32 phystatus = GET_RX_DESC_PHYST(pdesc);

	u32 phystatus = get_rx_desc_physt(pdesc);



	status->length = (u16)GET_RX_DESC_PKT_LEN(pdesc);

	status->rx_drvinfo_size = (u8)GET_RX_DESC_DRV_INFO_SIZE(pdesc) *

	status->length = (u16)get_rx_desc_pkt_len(pdesc);

	status->rx_drvinfo_size = (u8)get_rx_desc_drv_info_size(pdesc) *

				  RX_DRV_INFO_SIZE_UNIT;

	status->rx_bufshift = (u8)(GET_RX_DESC_SHIFT(pdesc) & 0x03);

	status->icv = (u16) GET_RX_DESC_ICV(pdesc);

	status->crc = (u16) GET_RX_DESC_CRC32(pdesc);

	status->rx_bufshift = (u8)(get_rx_desc_shift(pdesc) & 0x03);

	status->icv = (u16)get_rx_desc_icv(pdesc);

	status->crc = (u16)get_rx_desc_crc32(pdesc);

	status->hwerror = (status->crc | status->icv);

	status->decrypted = !GET_RX_DESC_SWDEC(pdesc);

	status->rate = (u8)GET_RX_DESC_RXMCS(pdesc);

	status->shortpreamble = (u16)GET_RX_DESC_SPLCP(pdesc);

	status->isampdu = (bool)(GET_RX_DESC_PAGGR(pdesc) == 1);

	status->isfirst_ampdu = (bool)(GET_RX_DESC_PAGGR(pdesc) == 1);

	status->timestamp_low = GET_RX_DESC_TSFL(pdesc);

	status->rx_is40mhzpacket = (bool)GET_RX_DESC_BW(pdesc);

	status->bandwidth = (u8)GET_RX_DESC_BW(pdesc);

	status->macid = GET_RX_DESC_MACID(pdesc);

	status->is_ht = (bool)GET_RX_DESC_RXHT(pdesc);

	status->decrypted = !get_rx_desc_swdec(pdesc);

	status->rate = (u8)get_rx_desc_rxmcs(pdesc);

	status->shortpreamble = (u16)get_rx_desc_splcp(pdesc);

	status->isampdu = (bool)(get_rx_desc_paggr(pdesc) == 1);

	status->isfirst_ampdu = (bool)(get_rx_desc_paggr(pdesc) == 1);

	status->timestamp_low = get_rx_desc_tsfl(pdesc);

	status->rx_is40mhzpacket = (bool)get_rx_desc_bw(pdesc);

	status->bandwidth = (u8)get_rx_desc_bw(pdesc);

	status->macid = get_rx_desc_macid(pdesc);

	status->is_ht = (bool)get_rx_desc_rxht(pdesc);



	status->is_cck = RX_HAL_IS_CCK_RATE(status->rate);



	if (GET_RX_STATUS_DESC_RPT_SEL(pdesc))

	if (get_rx_status_desc_rpt_sel(pdesc))

		status->packet_report_type = C2H_PACKET;

	else

		status->packet_report_type = NORMAL_RX;





	if (GET_RX_STATUS_DESC_PATTERN_MATCH(pdesc))

	if (get_rx_status_desc_pattern_match(pdesc))

		wake_match = BIT(2);

	else if (GET_RX_STATUS_DESC_MAGIC_MATCH(pdesc))

	else if (get_rx_status_desc_magic_match(pdesc))

		wake_match = BIT(1);

	else if (GET_RX_STATUS_DESC_UNICAST_MATCH(pdesc))

	else if (get_rx_status_desc_unicast_match(pdesc))

		wake_match = BIT(0);

	else

		wake_match = 0;
@@ -392,9 +392,9 @@ bool rtl8723be_rx_query_desc(struct ieee80211_hw *hw, 
	rx_status->signal = status->recvsignalpower + 10;

	if (status->packet_report_type == TX_REPORT2) {

		status->macid_valid_entry[0] =

		  GET_RX_RPT2_DESC_MACID_VALID_1(pdesc);

		  get_rx_rpt2_desc_macid_valid_1(pdesc);

		status->macid_valid_entry[1] =

		  GET_RX_RPT2_DESC_MACID_VALID_2(pdesc);

		  get_rx_rpt2_desc_macid_valid_2(pdesc);

	}

	return true;

}
@@ -453,8 +453,8 @@ void rtl8723be_tx_fill_desc(struct ieee80211_hw *hw, 
	}

	if (firstseg) {

		if (rtlhal->earlymode_enable) {

			SET_TX_DESC_PKT_OFFSET(pdesc, 1);

			SET_TX_DESC_OFFSET(pdesc, USB_HWDESC_HEADER_LEN +

			set_tx_desc_pkt_offset(pdesc, 1);

			set_tx_desc_offset(pdesc, USB_HWDESC_HEADER_LEN +

					   EM_HDR_LEN);

			if (ptcb_desc->empkt_num) {

				RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,
@@ -464,60 +464,60 @@ void rtl8723be_tx_fill_desc(struct ieee80211_hw *hw, 
							    (u8 *)(skb->data));

			}

		} else {

			SET_TX_DESC_OFFSET(pdesc, USB_HWDESC_HEADER_LEN);

			set_tx_desc_offset(pdesc, USB_HWDESC_HEADER_LEN);

		}





		/* ptcb_desc->use_driver_rate = true; */

		SET_TX_DESC_TX_RATE(pdesc, ptcb_desc->hw_rate);

		set_tx_desc_tx_rate(pdesc, ptcb_desc->hw_rate);

		if (ptcb_desc->hw_rate > DESC92C_RATEMCS0)

			short_gi = (ptcb_desc->use_shortgi) ? 1 : 0;

		else

			short_gi = (ptcb_desc->use_shortpreamble) ? 1 : 0;



		SET_TX_DESC_DATA_SHORTGI(pdesc, short_gi);

		set_tx_desc_data_shortgi(pdesc, short_gi);



		if (info->flags & IEEE80211_TX_CTL_AMPDU) {

			SET_TX_DESC_AGG_ENABLE(pdesc, 1);

			SET_TX_DESC_MAX_AGG_NUM(pdesc, 0x14);

			set_tx_desc_agg_enable(pdesc, 1);

			set_tx_desc_max_agg_num(pdesc, 0x14);

		}

		SET_TX_DESC_SEQ(pdesc, seq_number);

		SET_TX_DESC_RTS_ENABLE(pdesc, ((ptcb_desc->rts_enable &&

		set_tx_desc_seq(pdesc, seq_number);

		set_tx_desc_rts_enable(pdesc, ((ptcb_desc->rts_enable &&

						!ptcb_desc->cts_enable) ?

						1 : 0));

		SET_TX_DESC_HW_RTS_ENABLE(pdesc, 0);

		SET_TX_DESC_CTS2SELF(pdesc, ((ptcb_desc->cts_enable) ?

		set_tx_desc_hw_rts_enable(pdesc, 0);

		set_tx_desc_cts2self(pdesc, ((ptcb_desc->cts_enable) ?

					      1 : 0));



		SET_TX_DESC_RTS_RATE(pdesc, ptcb_desc->rts_rate);

		set_tx_desc_rts_rate(pdesc, ptcb_desc->rts_rate);



		SET_TX_DESC_RTS_SC(pdesc, ptcb_desc->rts_sc);

		SET_TX_DESC_RTS_SHORT(pdesc,

		set_tx_desc_rts_sc(pdesc, ptcb_desc->rts_sc);

		set_tx_desc_rts_short(pdesc,

			((ptcb_desc->rts_rate <= DESC92C_RATE54M) ?

			 (ptcb_desc->rts_use_shortpreamble ? 1 : 0) :

			 (ptcb_desc->rts_use_shortgi ? 1 : 0)));



		if (ptcb_desc->tx_enable_sw_calc_duration)

			SET_TX_DESC_NAV_USE_HDR(pdesc, 1);

			set_tx_desc_nav_use_hdr(pdesc, 1);



		if (bw_40) {

			if (ptcb_desc->packet_bw == HT_CHANNEL_WIDTH_20_40) {

				SET_TX_DESC_DATA_BW(pdesc, 1);

				SET_TX_DESC_TX_SUB_CARRIER(pdesc, 3);

				set_tx_desc_data_bw(pdesc, 1);

				set_tx_desc_tx_sub_carrier(pdesc, 3);

			} else {

				SET_TX_DESC_DATA_BW(pdesc, 0);

				SET_TX_DESC_TX_SUB_CARRIER(pdesc, mac->cur_40_prime_sc);

				set_tx_desc_data_bw(pdesc, 0);

				set_tx_desc_tx_sub_carrier(pdesc, mac->cur_40_prime_sc);

			}

		} else {

			SET_TX_DESC_DATA_BW(pdesc, 0);

			SET_TX_DESC_TX_SUB_CARRIER(pdesc, 0);

			set_tx_desc_data_bw(pdesc, 0);

			set_tx_desc_tx_sub_carrier(pdesc, 0);

		}



		SET_TX_DESC_LINIP(pdesc, 0);

		SET_TX_DESC_PKT_SIZE(pdesc, (u16) skb_len);

		set_tx_desc_linip(pdesc, 0);

		set_tx_desc_pkt_size(pdesc, (u16)skb_len);

		if (sta) {

			u8 ampdu_density = sta->ht_cap.ampdu_density;

			SET_TX_DESC_AMPDU_DENSITY(pdesc, ampdu_density);

			set_tx_desc_ampdu_density(pdesc, ampdu_density);

		}

		if (info->control.hw_key) {

			struct ieee80211_key_conf *keyconf =
@@ -526,23 +526,23 @@ void rtl8723be_tx_fill_desc(struct ieee80211_hw *hw, 
			case WLAN_CIPHER_SUITE_WEP40:

			case WLAN_CIPHER_SUITE_WEP104:

			case WLAN_CIPHER_SUITE_TKIP:

				SET_TX_DESC_SEC_TYPE(pdesc, 0x1);

				set_tx_desc_sec_type(pdesc, 0x1);

				break;

			case WLAN_CIPHER_SUITE_CCMP:

				SET_TX_DESC_SEC_TYPE(pdesc, 0x3);

				set_tx_desc_sec_type(pdesc, 0x3);

				break;

			default:

				SET_TX_DESC_SEC_TYPE(pdesc, 0x0);

				set_tx_desc_sec_type(pdesc, 0x0);

				break;

			}

		}



		SET_TX_DESC_QUEUE_SEL(pdesc, fw_qsel);

		SET_TX_DESC_DATA_RATE_FB_LIMIT(pdesc, 0x1F);

		SET_TX_DESC_RTS_RATE_FB_LIMIT(pdesc, 0xF);

		SET_TX_DESC_DISABLE_FB(pdesc, ptcb_desc->disable_ratefallback ?

		set_tx_desc_queue_sel(pdesc, fw_qsel);

		set_tx_desc_data_rate_fb_limit(pdesc, 0x1F);

		set_tx_desc_rts_rate_fb_limit(pdesc, 0xF);

		set_tx_desc_disable_fb(pdesc, ptcb_desc->disable_ratefallback ?

					      1 : 0);

		SET_TX_DESC_USE_RATE(pdesc, ptcb_desc->use_driver_rate ? 1 : 0);

		set_tx_desc_use_rate(pdesc, ptcb_desc->use_driver_rate ? 1 : 0);



		/* Set TxRate and RTSRate in TxDesc  */

		/* This prevent Tx initial rate of new-coming packets */
@@ -551,34 +551,34 @@ void rtl8723be_tx_fill_desc(struct ieee80211_hw *hw, 
			if (mac->rdg_en) {

				RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE,

					 "Enable RDG function.\n");

				SET_TX_DESC_RDG_ENABLE(pdesc, 1);

				SET_TX_DESC_HTC(pdesc, 1);

				set_tx_desc_rdg_enable(pdesc, 1);

				set_tx_desc_htc(pdesc, 1);

			}

		}

		/* tx report */

		rtl_set_tx_report(ptcb_desc, pdesc, hw, tx_info);

	}



	SET_TX_DESC_FIRST_SEG(pdesc, (firstseg ? 1 : 0));

	SET_TX_DESC_LAST_SEG(pdesc, (lastseg ? 1 : 0));

	SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16) buf_len);

	SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, mapping);

	set_tx_desc_first_seg(pdesc, (firstseg ? 1 : 0));

	set_tx_desc_last_seg(pdesc, (lastseg ? 1 : 0));

	set_tx_desc_tx_buffer_size(pdesc, (u16)buf_len);

	set_tx_desc_tx_buffer_address(pdesc, mapping);

	/* if (rtlpriv->dm.useramask) { */

	if (1) {

		SET_TX_DESC_RATE_ID(pdesc, ptcb_desc->ratr_index);

		SET_TX_DESC_MACID(pdesc, ptcb_desc->mac_id);

		set_tx_desc_rate_id(pdesc, ptcb_desc->ratr_index);

		set_tx_desc_macid(pdesc, ptcb_desc->mac_id);

	} else {

		SET_TX_DESC_RATE_ID(pdesc, 0xC + ptcb_desc->ratr_index);

		SET_TX_DESC_MACID(pdesc, ptcb_desc->mac_id);

		set_tx_desc_rate_id(pdesc, 0xC + ptcb_desc->ratr_index);

		set_tx_desc_macid(pdesc, ptcb_desc->mac_id);

	}

	if (!ieee80211_is_data_qos(fc))  {

		SET_TX_DESC_HWSEQ_EN(pdesc, 1);

		SET_TX_DESC_HWSEQ_SEL(pdesc, 0);

		set_tx_desc_hwseq_en(pdesc, 1);

		set_tx_desc_hwseq_sel(pdesc, 0);

	}

	SET_TX_DESC_MORE_FRAG(pdesc, (lastseg ? 0 : 1));

	set_tx_desc_more_frag(pdesc, (lastseg ? 0 : 1));

	if (is_multicast_ether_addr(ieee80211_get_DA(hdr)) ||

	    is_broadcast_ether_addr(ieee80211_get_DA(hdr))) {

		SET_TX_DESC_BMC(pdesc, 1);

		set_tx_desc_bmc(pdesc, 1);

	}



	RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n");
@@ -603,34 +603,34 @@ void rtl8723be_tx_fill_cmddesc(struct ieee80211_hw *hw, u8 *pdesc, 
	}

	CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE);



	SET_TX_DESC_OFFSET(pdesc, USB_HWDESC_HEADER_LEN);

	set_tx_desc_offset(pdesc, USB_HWDESC_HEADER_LEN);



	SET_TX_DESC_TX_RATE(pdesc, DESC92C_RATE1M);

	set_tx_desc_tx_rate(pdesc, DESC92C_RATE1M);



	SET_TX_DESC_SEQ(pdesc, 0);

	set_tx_desc_seq(pdesc, 0);



	SET_TX_DESC_LINIP(pdesc, 0);

	set_tx_desc_linip(pdesc, 0);



	SET_TX_DESC_QUEUE_SEL(pdesc, fw_queue);

	set_tx_desc_queue_sel(pdesc, fw_queue);



	SET_TX_DESC_FIRST_SEG(pdesc, 1);

	SET_TX_DESC_LAST_SEG(pdesc, 1);

	set_tx_desc_first_seg(pdesc, 1);

	set_tx_desc_last_seg(pdesc, 1);



	SET_TX_DESC_TX_BUFFER_SIZE(pdesc, (u16)(skb->len));

	set_tx_desc_tx_buffer_size(pdesc, (u16)(skb->len));



	SET_TX_DESC_TX_BUFFER_ADDRESS(pdesc, mapping);

	set_tx_desc_tx_buffer_address(pdesc, mapping);



	SET_TX_DESC_RATE_ID(pdesc, 0);

	SET_TX_DESC_MACID(pdesc, 0);

	set_tx_desc_rate_id(pdesc, 0);

	set_tx_desc_macid(pdesc, 0);



	SET_TX_DESC_OWN(pdesc, 1);

	set_tx_desc_own(pdesc, 1);



	SET_TX_DESC_PKT_SIZE((u8 *)pdesc, (u16)(skb->len));

	set_tx_desc_pkt_size((u8 *)pdesc, (u16)(skb->len));



	SET_TX_DESC_FIRST_SEG(pdesc, 1);

	SET_TX_DESC_LAST_SEG(pdesc, 1);

	set_tx_desc_first_seg(pdesc, 1);

	set_tx_desc_last_seg(pdesc, 1);



	SET_TX_DESC_USE_RATE(pdesc, 1);

	set_tx_desc_use_rate(pdesc, 1);



	RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD,

		      "H2C Tx Cmd Content\n", pdesc, TX_DESC_SIZE);
@@ -642,10 +642,10 @@ void rtl8723be_set_desc(struct ieee80211_hw *hw, u8 *pdesc, 
	if (istx) {

		switch (desc_name) {

		case HW_DESC_OWN:

			SET_TX_DESC_OWN(pdesc, 1);

			set_tx_desc_own(pdesc, 1);

			break;

		case HW_DESC_TX_NEXTDESC_ADDR:

			SET_TX_DESC_NEXT_DESC_ADDRESS(pdesc, *(u32 *)val);

			set_tx_desc_next_desc_address(pdesc, *(u32 *)val);

			break;

		default:

			WARN_ONCE(true, "rtl8723be: ERR txdesc :%d not processed\n",
@@ -655,16 +655,16 @@ void rtl8723be_set_desc(struct ieee80211_hw *hw, u8 *pdesc, 
	} else {

		switch (desc_name) {

		case HW_DESC_RXOWN:

			SET_RX_DESC_OWN(pdesc, 1);

			set_rx_desc_own(pdesc, 1);

			break;

		case HW_DESC_RXBUFF_ADDR:

			SET_RX_DESC_BUFF_ADDR(pdesc, *(u32 *)val);

			set_rx_desc_buff_addr(pdesc, *(u32 *)val);

			break;

		case HW_DESC_RXPKT_LEN:

			SET_RX_DESC_PKT_LEN(pdesc, *(u32 *)val);

			set_rx_desc_pkt_len(pdesc, *(u32 *)val);

			break;

		case HW_DESC_RXERO:

			SET_RX_DESC_EOR(pdesc, 1);

			set_rx_desc_eor(pdesc, 1);

			break;

		default:

			WARN_ONCE(true, "rtl8723be: ERR rxdesc :%d not process\n",
@@ -682,10 +682,10 @@ u64 rtl8723be_get_desc(struct ieee80211_hw *hw, 
	if (istx) {

		switch (desc_name) {

		case HW_DESC_OWN:

			ret = GET_TX_DESC_OWN(pdesc);

			ret = get_tx_desc_own(pdesc);

			break;

		case HW_DESC_TXBUFF_ADDR:

			ret = GET_TX_DESC_TX_BUFFER_ADDRESS(pdesc);

			ret = get_tx_desc_tx_buffer_address(pdesc);

			break;

		default:

			WARN_ONCE(true, "rtl8723be: ERR txdesc :%d not process\n",
@@ -695,13 +695,13 @@ u64 rtl8723be_get_desc(struct ieee80211_hw *hw, 
	} else {

		switch (desc_name) {

		case HW_DESC_OWN:

			ret = GET_RX_DESC_OWN(pdesc);

			ret = get_rx_desc_own(pdesc);

			break;

		case HW_DESC_RXPKT_LEN:

			ret = GET_RX_DESC_PKT_LEN(pdesc);

			ret = get_rx_desc_pkt_len(pdesc);

			break;

		case HW_DESC_RXBUFF_ADDR:

			ret = GET_RX_DESC_BUFF_ADDR(pdesc);

			ret = get_rx_desc_buff_addr(pdesc);

			break;

		default:

			WARN_ONCE(true, "rtl8723be: ERR rxdesc :%d not processed\n",

drivers/net/wireless/realtek/rtlwifi/rtl8723be/trx.h

+368 −170

File changed.

Preview size limit exceeded, changes collapsed.

CRA Git | Maintained and supported by SUSTech CRA and CCSE