Commit d79d176a authored Oct 13, 2020 by Baoquan He Committed by Linus Torvalds Oct 13, 2020

mm/hugetlb.c: remove the unnecessary non_swap_entry()



If a swap entry tests positive for either is_[migration|hwpoison]_entry(),
then its swap_type() is among SWP_MIGRATION_READ, SWP_MIGRATION_WRITE and
SWP_HWPOISON.  All these types >= MAX_SWAPFILES, exactly what is asserted
with non_swap_entry().

So the checking non_swap_entry() in is_hugetlb_entry_migration() and
is_hugetlb_entry_hwpoisoned() is redundant.

Let's remove it to optimize code.

Signed-off-by: Baoquan He <bhe@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Link: https://lkml.kernel.org/r/20200723032248.24772-3-bhe@redhat.com


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3e5c3600

mm/hugetlb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -3799,7 +3799,7 @@ bool is_hugetlb_entry_migration(pte_t pte)
		if (huge_pte_none(pte) \|\| pte_present(pte))
		return false;
		swp = pte_to_swp_entry(pte);
		if (non_swap_entry(swp) && is_migration_entry(swp))
		if (is_migration_entry(swp))
		return true;
		else
		return false;
		@@ -3812,7 +3812,7 @@ static bool is_hugetlb_entry_hwpoisoned(pte_t pte)
		if (huge_pte_none(pte) \|\| pte_present(pte))
		return false;
		swp = pte_to_swp_entry(pte);
		if (non_swap_entry(swp) && is_hwpoison_entry(swp))
		if (is_hwpoison_entry(swp))
		return true;
		else
		return false;

Admin message