Commit d79cdc83 authored Aug 08, 2013 by Daniel Vetter Committed by Dave Airlie Aug 19, 2013

drm: no-op out GET_STATS ioctl



Again only used by a tests in libdrm and by dristat. Nowadays we have
much better tracing tools to get detailed insights into what a drm
driver is doing. And for a simple "does it work" kind of question that
these stats could answer we have plenty of dmesg debug log spew.

So I don't see any use for this stat gathering complexity at all.

To be able to gradually drop things start with ripping out the
interfaces to it, here the ioctl.

To prevent dristat from eating its own stack garbage we can't use the
drm_noop ioctl though, since we need to clear the return data with a
memset.

Cc: Eric Anholt <eric@anholt.net>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Reviewed-by: Eric Anholt <eric@anholt.net>
Signed-off-by: Dave Airlie <airlied@redhat.com>

parent 719524df

drivers/gpu/drm/drm_ioctl.c

+1 −12

Original line number	Diff line number	Diff line
		@@ -257,21 +257,10 @@ int drm_getstats(struct drm_device dev, void data,
		struct drm_file *file_priv)
		{
		struct drm_stats *stats = data;
		int i;

		/* Clear stats to prevent userspace from eating its stack garbage. */
		memset(stats, 0, sizeof(*stats));

		for (i = 0; i < dev->counters; i++) {
		if (dev->types[i] == _DRM_STAT_LOCK)
		stats->data[i].value =
		(file_priv->master->lock.hw_lock ? file_priv->master->lock.hw_lock->lock : 0);
		else
		stats->data[i].value = atomic_read(&dev->counts[i]);
		stats->data[i].type = dev->types[i];
		}

		stats->count = dev->counters;

		return 0;
		}

Admin message