Commit d742cdd6 authored by Emil Velikov's avatar Emil Velikov Committed by Emil Velikov
Browse files

drm/omapdrm: remove _unlocked suffix in drm_gem_object_put_unlocked 



Spelling out _unlocked for each and every driver is a annoying.
Especially if we consider how many drivers, do not know (or need to)
about the horror stories involving struct_mutex.

Just drop the suffix. It makes the API cleaner.

Done via the following script:

__from=drm_gem_object_put_unlocked
__to=drm_gem_object_put
for __file in $(git grep --name-only $__from); do
  sed -i  "s/$__from/$__to/g" $__file;
done

Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Acked-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20200515095118.2743122-27-emil.l.velikov@gmail.com
parent cdc194ce

drivers/gpu/drm/omapdrm/omap_drv.c

+1 −1
Original line number Diff line number Diff line
@@ -503,7 +503,7 @@ static int ioctl_gem_info(struct drm_device *dev, void *data, 
	args->size = omap_gem_mmap_size(obj);

	args->offset = omap_gem_mmap_offset(obj);



	drm_gem_object_put_unlocked(obj);

	drm_gem_object_put(obj);



	return ret;

}

drivers/gpu/drm/omapdrm/omap_fb.c

+1 −1
Original line number Diff line number Diff line
@@ -326,7 +326,7 @@ struct drm_framebuffer *omap_framebuffer_create(struct drm_device *dev, 


error:

	while (--i >= 0)

		drm_gem_object_put_unlocked(bos[i]);

		drm_gem_object_put(bos[i]);



	return fb;

}

drivers/gpu/drm/omapdrm/omap_fbdev.c

+1 −1
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, 
		/* note: if fb creation failed, we can't rely on fb destroy

		 * to unref the bo:

		 */

		drm_gem_object_put_unlocked(fbdev->bo);

		drm_gem_object_put(fbdev->bo);

		ret = PTR_ERR(fb);

		goto fail;

	}

drivers/gpu/drm/omapdrm/omap_gem.c

+2 −2
Original line number Diff line number Diff line
@@ -629,7 +629,7 @@ int omap_gem_dumb_map_offset(struct drm_file *file, struct drm_device *dev, 


	*offset = omap_gem_mmap_offset(obj);



	drm_gem_object_put_unlocked(obj);

	drm_gem_object_put(obj);



fail:

	return ret;
@@ -1348,7 +1348,7 @@ int omap_gem_new_handle(struct drm_device *dev, struct drm_file *file, 
	}



	/* drop reference from allocate - handle holds it now */

	drm_gem_object_put_unlocked(obj);

	drm_gem_object_put(obj);



	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE