Commit d735d25e authored Dec 10, 2014 by Fabio Estevam Committed by Rafael J. Wysocki Dec 10, 2014

leds: leds-gpio: Fix the "default-state" property check



Commit a43f2cbb ("leds: leds-gpio: Make use of device property API")
caused a regression by reading the incorrect string for the "default-state"
property.

Fix the property string check to restore the original behaviour.

Fixes: a43f2cbb (leds: leds-gpio: Make use of device property API)
Reported-by: Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Bryan Wu <cooloney@gmail.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 29470ea8

drivers/leds/leds-gpio.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -203,7 +203,7 @@ static struct gpio_leds_priv gpio_leds_create(struct platform_device pdev)
	fwnode_property_read_string(child, "linux,default-trigger",		fwnode_property_read_string(child, "linux,default-trigger",
	&led.default_trigger);		&led.default_trigger);

	if (!fwnode_property_read_string(child, "linux,default_state",		if (!fwnode_property_read_string(child, "default-state",
	&state)) {		&state)) {
	if (!strcmp(state, "keep"))		if (!strcmp(state, "keep"))
	led.default_state = LEDS_GPIO_DEFSTATE_KEEP;		led.default_state = LEDS_GPIO_DEFSTATE_KEEP;

Admin message