Commit d723a92d authored Oct 10, 2013 by Benjamin Herrenschmidt Committed by Greg Kroah-Hartman Oct 14, 2013

sysfs/bin: Fix size handling overflow for bin_attribute



While looking at the code, I noticed that bin_attribute read() and write()
ops copy the inode size into an int for futher comparisons.

Some bin_attributes can be fairly large. For example, pci creates some for
BARs set to the BAR size and giant BARs are around the corner, so this is
going to break something somewhere eventually.

Let's use the right type.

[adjust for seqfile conversions, only needed for bin_read() - gkh]

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Tejun Heo <tj@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 785a162d

fs/sysfs/file.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -156,7 +156,7 @@ static ssize_t sysfs_bin_read(struct file file, char __user userbuf,
		struct sysfs_open_file *of = sysfs_of(file);
		struct bin_attribute *battr = of->sd->s_bin_attr.bin_attr;
		struct kobject *kobj = of->sd->s_parent->s_dir.kobj;
		int size = file_inode(file)->i_size;
		loff_t size = file_inode(file)->i_size;
		int count = min_t(size_t, bytes, PAGE_SIZE);
		loff_t offs = *off;
		char *buf;

Admin message