Commit d6f93829 authored Jun 22, 2014 by Viresh Kumar Committed by Thomas Gleixner Jun 23, 2014

timer: Store cpu-number in struct tvec_base



Timers are serviced by the tick. But when a timer is enqueued on a
dynticks target, we need to kick it in order to make it reconsider the
next tick to schedule to correctly handle the timer's expiring time.

Now while this kick is correctly performed for add_timer_on(), the
mod_timer*() family has been a bit neglected.

To prepare for fixing this, we need internal_add_timer() to be able to
resolve the CPU target associated to a timer's object 'base' so that the
kick can be centralized there.

This can't be passed as an argument as not all the callers know the CPU
number of a timer's base. So lets store it in the struct tvec_base to
resolve the CPU without much overhead. It is set once for good at every
CPU's first boot.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Link: http://lkml.kernel.org/r/1403393357-2070-2-git-send-email-fweisbec@gmail.com


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 5cee9645

kernel/time/timer.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -82,6 +82,7 @@ struct tvec_base {
		unsigned long next_timer;
		unsigned long active_timers;
		unsigned long all_timers;
		int cpu;
		struct tvec_root tv1;
		struct tvec tv2;
		struct tvec tv3;
		@@ -1568,6 +1569,7 @@ static int init_timers_cpu(int cpu)
		}
		spin_lock_init(&base->lock);
		tvec_base_done[cpu] = 1;
		base->cpu = cpu;
		} else {
		base = per_cpu(tvec_bases, cpu);
		}

Admin message