Commit d6eb71a6 authored Sep 23, 2015 by Vaibhav Jain Committed by Michael Ellerman Sep 23, 2015

cxl: Fix lockdep warning while creating afu_err_buff attribute



Presently a lockdep warning is reported during creation of afu_err_buff
bin_attribute for the afu. This is caused due to the variable attr.key
not pointing to a static class key, hence the function lockdep_init_map
reports this warning:

 BUG: key <some-address> not in .data!

The patch fixes this issue by calling sysfs_attr_init on the
attr_eb.attr structure before populating it with the afu_err_buff file
details. This will populate the attr.key variable with a static class
key so that lockdep_init_map stops complaining about the lockdep key not
being static.

Reported-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Acked-by: Ian Munsie <imunsie@au1.ibm.com>
Reviewed-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 793b8bf9

drivers/misc/cxl/sysfs.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -592,6 +592,8 @@ int cxl_sysfs_afu_add(struct cxl_afu *afu)

		/* conditionally create the add the binary file for error info buffer */
		if (afu->eb_len) {
		sysfs_attr_init(&afu->attr_eb.attr);

		afu->attr_eb.attr.name = "afu_err_buff";
		afu->attr_eb.attr.mode = S_IRUGO;
		afu->attr_eb.size = afu->eb_len;

Admin message