Commit d6e3f838 authored Mar 20, 2020 by Junaid Shahid Committed by Paolo Bonzini Apr 15, 2020

KVM: nVMX: Invalidate all roots when emulating INVVPID without EPT



Free all roots when emulating INVVPID for L1 and EPT is disabled, as
outstanding changes to the page tables managed by L1 need to be
recognized.  Because L1 and L2 share an MMU when EPT is disabled, and
because VPID is not tracked by the MMU role, all roots in the current
MMU (root_mmu) need to be freed, otherwise a future nested VM-Enter or
VM-Exit could do a fast CR3 switch (without a flush/sync) and consume
stale SPTEs.

Fixes: 5c614b35 ("KVM: nVMX: nested VPID emulation")
Signed-off-by: Junaid Shahid <junaids@google.com>
[sean: ported to upstream KVM, reworded the comment and changelog]
Signed-off-by: Sean Christopherson <sean.j.christopherson@intel.com>
Message-Id: <20200320212833.3507-5-sean.j.christopherson@intel.com>
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent f8aa7e39

arch/x86/kvm/vmx/nested.c

+14 −0

Original line number	Diff line number	Diff line
		@@ -5255,6 +5255,20 @@ static int handle_invvpid(struct kvm_vcpu *vcpu)
		return kvm_skip_emulated_instruction(vcpu);
		}

		/*
		* Sync the shadow page tables if EPT is disabled, L1 is invalidating
		* linear mappings for L2 (tagged with L2's VPID). Free all roots as
		* VPIDs are not tracked in the MMU role.
		*
		* Note, this operates on root_mmu, not guest_mmu, as L1 and L2 share
		* an MMU when EPT is disabled.
		*
		* TODO: sync only the affected SPTEs for INVDIVIDUAL_ADDR.
		*/
		if (!enable_ept)
		kvm_mmu_free_roots(vcpu, &vcpu->arch.root_mmu,
		KVM_MMU_ROOTS_ALL);

		return nested_vmx_succeed(vcpu);
		}

Admin message