Commit d6cc7685 authored Nov 04, 2011 by Tejun Heo Committed by Rafael J. Wysocki Nov 04, 2011

Freezer: Make fake_signal_wake_up() wake...


PM / Freezer: Revert 27920651 "PM / Freezer: Make fake_signal_wake_up() wake TASK_KILLABLE tasks too"

Commit 27920651 "PM / Freezer: Make fake_signal_wake_up() wake
TASK_KILLABLE tasks too" updated fake_signal_wake_up() used by freezer
to wake up KILLABLE tasks.  Sending unsolicited wakeups to tasks in
killable sleep is dangerous as there are code paths which depend on
tasks not waking up spuriously from KILLABLE sleep.

For example. sys_read() or page can sleep in TASK_KILLABLE assuming
that wait/down/whatever _killable can only fail if we can not return
to the usermode.  TASK_TRACED is another obvious example.

The previous patch updated wait_event_freezekillable() such that it
doesn't depend on the spurious wakeup.  This patch reverts the
offending commit.

Note that the spurious KILLABLE wakeup had other implicit effects in
KILLABLE sleeps in nfs and cifs and those will need further updates to
regain freezekillable behavior.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

parent 6f35c4ab

kernel/freezer.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,7 @@ static void fake_signal_wake_up(struct task_struct *p)
		unsigned long flags;

		spin_lock_irqsave(&p->sighand->siglock, flags);
		signal_wake_up(p, 1);
		signal_wake_up(p, 0);
		spin_unlock_irqrestore(&p->sighand->siglock, flags);
		}

Admin message